Re: [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for your review!

On 13.07.23, Sergey Kaplun wrote:
> Hi, Igor!
> The patch LGTM as general, just a single note, also mentioned by Sergey
> offline:
> 
> Should we also enable LUAJIT_USE_SYSMALLOC for our CI workflow to make
> the ASan instrumentation usefull?

I added the warning in CMake, if LUAJIT_USE_ASAN is enabled without
LUAJIT_USE_SYSMALLOC, and enabled it in CI. See the second version of
the series[1] for updates.

> 
> On 12.07.23, Igor Munkin wrote:
> > This commit adds GitHub workflow running all available LuaJIT tests with
> > LUAJIT_USE_ASAN option enabled. For now, sanitizers workflow works only
> > for Linux/x86_64 as the most scaling setup in our CI. I believe we will
> > be able to add other platforms being supported, when ARM64 and macOS
> > runners starvation is defeated. There is also a separate GitHub Action
> > introduced for convenient setup of the environment.
> > 
> > Follows up tarantool/tarantool#5878
> > 
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> 
> <snipped>
> 
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

[1]: https://lists.tarantool.org/tarantool-patches/cover.1689925402.git.imun@tarantool.org/T/#t

-- 
Best regards,
IM