Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers
Date: Thu, 13 Jul 2023 19:09:08 +0300	[thread overview]
Message-ID: <ZLAhpPjPj/drexV/@root> (raw)
In-Reply-To: <14eab2dd6a619fb33d9b82bd24b4c2515184659d.1689195028.git.imun@tarantool.org>

Hi, Igor!
The patch LGTM as general, just a single note, also mentioned by Sergey
offline:

Should we also enable LUAJIT_USE_SYSMALLOC for our CI workflow to make
the ASan instrumentation usefull?

On 12.07.23, Igor Munkin wrote:
> This commit adds GitHub workflow running all available LuaJIT tests with
> LUAJIT_USE_ASAN option enabled. For now, sanitizers workflow works only
> for Linux/x86_64 as the most scaling setup in our CI. I believe we will
> be able to add other platforms being supported, when ARM64 and macOS
> runners starvation is defeated. There is also a separate GitHub Action
> introduced for convenient setup of the environment.
> 
> Follows up tarantool/tarantool#5878
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>

<snipped>

> 

-- 
Best regards,
Sergey Kaplun

  parent reply	other threads:[~2023-07-13 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 21:09 [Tarantool-patches] [PATCH luajit 0/2] Add ASan support in LuaJIT Igor Munkin via Tarantool-patches
2023-07-12 21:09 ` [Tarantool-patches] [PATCH luajit 1/2] build: introduce LUAJIT_USE_ASAN option Igor Munkin via Tarantool-patches
2023-07-13 10:47   ` Sergey Kaplun via Tarantool-patches
2023-07-13 11:52   ` Sergey Bronnikov via Tarantool-patches
2023-07-21  8:13     ` Igor Munkin via Tarantool-patches
2023-07-12 21:09 ` [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers Igor Munkin via Tarantool-patches
2023-07-13 12:12   ` Sergey Bronnikov via Tarantool-patches
2023-07-21  8:14     ` Igor Munkin via Tarantool-patches
2023-07-13 16:09   ` Sergey Kaplun via Tarantool-patches [this message]
2023-07-21  8:13     ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLAhpPjPj/drexV/@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox