From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <estetus@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/1] Fix saved bytecode encapsulated in ELF objects. Date: Tue, 4 Jul 2023 17:09:34 +0000 [thread overview] Message-ID: <ZKRSTkD7+I9g3Ydl@tarantool.org> (raw) In-Reply-To: <7be88fa24695ad2f3c15a9a23bd884ca0acc36f5.1685433737.git.sergeyb@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master and release/2.11. Considering the tests specifics, it's not trivial to adjust it for release/2.10 (since there is no -b option in the old versions). On 30.05.23, Sergey Bronnikov via Tarantool-patches wrote: > From: Sergey Bronnikov <sergeyb@tarantool.org> > > Thanks to Dimitry Andric. > > (cherry picked from commit 7dbf0b05f1228c1c719866db5e5f3d58f87f74c8) > > Function `bcsave.lua:bcsave_elfobj()` produced an object file in ELF > format with a wrong size size of `.strtab`. Wrong .strtab size causes lld to > show an error message: > > ``` > $ luajit -b -n "module_name" -e "print()" xxx.obj > $ ld.lld xxx.obj > ld.lld: error: xxx.obj: SHT_STRTAB string table section [index 3] is non-null terminated > ``` > > Sergey Bronnikov: > * added the description and the test for the problem > > Signed-off-by: Sergey Bronnikov <sergeyb@tarantool.org> > Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> > Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org> > --- > > Changes in v2: > - Fixed comments as per review by Sergey. > > Branch: https://github.com/tarantool/luajit/tree/ligurio/gh-366-strtab-section-correct-size > Tarantool CI: https://github.com/ligurio/tarantool/tree/ligurio/gh-xxxx-strtab-section-correct-size > > src/jit/bcsave.lua | 2 +- > .../lj-366-strtab-correct-size.test.lua | 202 ++++++++++++++++++ > 2 files changed, 203 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-366-strtab-correct-size.test.lua > <snipped> > -- > 2.34.1 > -- Best regards, IM
prev parent reply other threads:[~2023-07-04 17:19 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-30 8:09 Sergey Bronnikov via Tarantool-patches 2023-05-30 9:05 ` Maxim Kokryashkin via Tarantool-patches 2023-05-31 14:50 ` Sergey Bronnikov via Tarantool-patches 2023-06-06 12:55 ` Sergey Kaplun via Tarantool-patches 2023-06-06 12:31 ` Sergey Kaplun via Tarantool-patches 2023-06-06 14:14 ` Sergey Bronnikov via Tarantool-patches 2023-07-04 17:09 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZKRSTkD7+I9g3Ydl@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=imun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2 1/1] Fix saved bytecode encapsulated in ELF objects.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox