From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EB3A34F62B0; Tue, 4 Jul 2023 20:19:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB3A34F62B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1688491149; bh=CLyeOzvir85EcitS/yC7mFvPgrS917DDcFqdXYbVTbI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KQamBN1iMrRb9IFmzPUv97KViRP2oGQ9B4/ORmGtRLKyj5bmznOI/71tM3XN+pMC7 ovQ3k9UYFYN2CXhqFT7x4EUtpmYCTnklWHqEzWjVowrjyKl9C0dJ8R+gtZQjw+8g88 shKQp5SV3ecX9ntsnr02xO27R7oa+pSn0MXcZNBo= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [95.163.41.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1B62C4F62AF for ; Tue, 4 Jul 2023 20:18:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B62C4F62AF Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1qGjfW-008GOk-47; Tue, 04 Jul 2023 20:18:26 +0300 Date: Tue, 4 Jul 2023 17:09:34 +0000 To: Sergey Bronnikov Message-ID: References: <7be88fa24695ad2f3c15a9a23bd884ca0acc36f5.1685433737.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7be88fa24695ad2f3c15a9a23bd884ca0acc36f5.1685433737.git.sergeyb@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90EBD74C6BAAC9DBAE23CD95C274A153CFC6B5948C61D86E6182A05F538085040FDB22F551F9975690147222F6ECCAA41BDC23EFF99B6CB7B414F3309C3CEB7FF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE751DD1FEBB966604DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379E389E29EFC3C6B78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C6D3E2CD77EB26456C20B9F40EFA889D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BECD08F8D939B2CE4A471835C12D1D977C4224003CC836476EB9C41850244470149FD398EE364050F0AC5B80A05675ACD4D0DA9BD313A0613B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A50B73C11B665112C8AAC92FB15C527888C7D02C5A921944C2F87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF40CD5DB89422F52EF0447C471A8C35FAEFD52EB2DDF4586E48DB0BD1B4F66A3617059C39C4D6624209C04BAA40F94CC3B7B86E526C1C03549DDF97B67B1E0244A74DFFEFA5DC0E7F02C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtu6fghEd2rVXCzyi9pUcxA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531DE778E16EE58547433779427FD4597463C5642EA9D5B86B02326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/1] Fix saved bytecode encapsulated in ELF objects. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master and release/2.11. Considering the tests specifics, it's not trivial to adjust it for release/2.10 (since there is no -b option in the old versions). On 30.05.23, Sergey Bronnikov via Tarantool-patches wrote: > From: Sergey Bronnikov > > Thanks to Dimitry Andric. > > (cherry picked from commit 7dbf0b05f1228c1c719866db5e5f3d58f87f74c8) > > Function `bcsave.lua:bcsave_elfobj()` produced an object file in ELF > format with a wrong size size of `.strtab`. Wrong .strtab size causes lld to > show an error message: > > ``` > $ luajit -b -n "module_name" -e "print()" xxx.obj > $ ld.lld xxx.obj > ld.lld: error: xxx.obj: SHT_STRTAB string table section [index 3] is non-null terminated > ``` > > Sergey Bronnikov: > * added the description and the test for the problem > > Signed-off-by: Sergey Bronnikov > Reviewed-by: Sergey Kaplun > Reviewed-by: Maxim Kokryashkin > --- > > Changes in v2: > - Fixed comments as per review by Sergey. > > Branch: https://github.com/tarantool/luajit/tree/ligurio/gh-366-strtab-section-correct-size > Tarantool CI: https://github.com/ligurio/tarantool/tree/ligurio/gh-xxxx-strtab-section-correct-size > > src/jit/bcsave.lua | 2 +- > .../lj-366-strtab-correct-size.test.lua | 202 ++++++++++++++++++ > 2 files changed, 203 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-366-strtab-correct-size.test.lua > > -- > 2.34.1 > -- Best regards, IM