* [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition
@ 2023-07-12 18:06 Igor Munkin via Tarantool-patches
2023-07-13 8:07 ` Sergey Kaplun via Tarantool-patches
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-07-12 18:06 UTC (permalink / raw)
To: Sergey Kaplun, Sergey Bronnikov; +Cc: tarantool-patches
As a result of branch renaming in LuaJIT repository, the existing job
concurrency group definition rule has become outdated. This patch
updates the condition according to the new branch naming policy.
Signed-off-by: Igor Munkin <imun@tarantool.org>
---
Branch: https://github.com/tarantool/luajit/tree/imun/ci-update-job-concurrency-group-def
.github/workflows/exotic-builds-testing.yml | 12 +++++-------
.github/workflows/gnumake-builds-testing.yml | 12 +++++-------
.github/workflows/lint.yml | 12 +++++-------
.github/workflows/testing.yml | 12 +++++-------
4 files changed, 20 insertions(+), 28 deletions(-)
diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
index 2269928f..318fb4dd 100644
--- a/.github/workflows/exotic-builds-testing.yml
+++ b/.github/workflows/exotic-builds-testing.yml
@@ -11,8 +11,8 @@ on:
concurrency:
# An update of a developer branch cancels the previously
# scheduled workflow run for this branch. However, the default
- # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
- # etc.) workflow runs are never canceled.
+ # branch, and long-term branch (tarantool/release/2.11,
+ # tarantool/release/2.10, etc) workflow runs are never canceled.
#
# We use a trick here: define the concurrency group as 'workflow
# run ID' + # 'workflow run attempt' because it is a unique
@@ -21,11 +21,9 @@ concurrency:
# XXX: we cannot use `github.sha` as a unique identifier because
# pushing a tag may cancel a run that works on a branch push
# event.
- group: ${{ (
- github.ref == 'refs/heads/tarantool' ||
- startsWith(github.ref, 'refs/heads/tarantool-')) &&
- format('{0}-{1}', github.run_id, github.run_attempt) ||
- format('{0}-{1}', github.workflow, github.ref) }}
+ group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
+ && format('{0}-{1}', github.run_id, github.run_attempt)
+ || format('{0}-{1}', github.workflow, github.ref) }}
cancel-in-progress: true
jobs:
diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
index b78823f1..afb96183 100644
--- a/.github/workflows/gnumake-builds-testing.yml
+++ b/.github/workflows/gnumake-builds-testing.yml
@@ -11,8 +11,8 @@ on:
concurrency:
# An update of a developer branch cancels the previously
# scheduled workflow run for this branch. However, the default
- # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
- # etc.) workflow runs are never canceled.
+ # branch, and long-term branch (tarantool/release/2.11,
+ # tarantool/release/2.10, etc) workflow runs are never canceled.
#
# We use a trick here: define the concurrency group as 'workflow
# run ID' + # 'workflow run attempt' because it is a unique
@@ -21,11 +21,9 @@ concurrency:
# XXX: we cannot use `github.sha` as a unique identifier because
# pushing a tag may cancel a run that works on a branch push
# event.
- group: ${{ (
- github.ref == 'refs/heads/tarantool' ||
- startsWith(github.ref, 'refs/heads/tarantool-')) &&
- format('{0}-{1}', github.run_id, github.run_attempt) ||
- format('{0}-{1}', github.workflow, github.ref) }}
+ group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
+ && format('{0}-{1}', github.run_id, github.run_attempt)
+ || format('{0}-{1}', github.workflow, github.ref) }}
cancel-in-progress: true
jobs:
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 71ceee9a..70c98104 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -11,8 +11,8 @@ on:
concurrency:
# An update of a developer branch cancels the previously
# scheduled workflow run for this branch. However, the default
- # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
- # etc.) workflow runs are never canceled.
+ # branch, and long-term branch (tarantool/release/2.11,
+ # tarantool/release/2.10, etc) workflow runs are never canceled.
#
# We use a trick here: define the concurrency group as 'workflow
# run ID' + # 'workflow run attempt' because it is a unique
@@ -21,11 +21,9 @@ concurrency:
# XXX: we cannot use `github.sha` as a unique identifier because
# pushing a tag may cancel a run that works on a branch push
# event.
- group: ${{ (
- github.ref == 'refs/heads/tarantool' ||
- startsWith(github.ref, 'refs/heads/tarantool-')) &&
- format('{0}-{1}', github.run_id, github.run_attempt) ||
- format('{0}-{1}', github.workflow, github.ref) }}
+ group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
+ && format('{0}-{1}', github.run_id, github.run_attempt)
+ || format('{0}-{1}', github.workflow, github.ref) }}
cancel-in-progress: true
jobs:
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index 8300c443..2c637124 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -11,8 +11,8 @@ on:
concurrency:
# An update of a developer branch cancels the previously
# scheduled workflow run for this branch. However, the default
- # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
- # etc.) workflow runs are never canceled.
+ # branch, and long-term branch (tarantool/release/2.11,
+ # tarantool/release/2.10, etc) workflow runs are never canceled.
#
# We use a trick here: define the concurrency group as 'workflow
# run ID' + # 'workflow run attempt' because it is a unique
@@ -21,11 +21,9 @@ concurrency:
# XXX: we cannot use `github.sha` as a unique identifier because
# pushing a tag may cancel a run that works on a branch push
# event.
- group: ${{ (
- github.ref == 'refs/heads/tarantool' ||
- startsWith(github.ref, 'refs/heads/tarantool-')) &&
- format('{0}-{1}', github.run_id, github.run_attempt) ||
- format('{0}-{1}', github.workflow, github.ref) }}
+ group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
+ && format('{0}-{1}', github.run_id, github.run_attempt)
+ || format('{0}-{1}', github.workflow, github.ref) }}
cancel-in-progress: true
jobs:
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition
2023-07-12 18:06 [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition Igor Munkin via Tarantool-patches
@ 2023-07-13 8:07 ` Sergey Kaplun via Tarantool-patches
2023-07-13 9:58 ` Sergey Bronnikov via Tarantool-patches
2023-07-13 17:06 ` Igor Munkin via Tarantool-patches
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2023-07-13 8:07 UTC (permalink / raw)
To: Igor Munkin; +Cc: tarantool-patches
Hi, Igor!
Thanks for the patch!
LGTM!
--
Best regards,
Sergey Kaplun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition
2023-07-12 18:06 [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition Igor Munkin via Tarantool-patches
2023-07-13 8:07 ` Sergey Kaplun via Tarantool-patches
@ 2023-07-13 9:58 ` Sergey Bronnikov via Tarantool-patches
2023-07-13 17:06 ` Igor Munkin via Tarantool-patches
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2023-07-13 9:58 UTC (permalink / raw)
To: Igor Munkin, Sergey Kaplun; +Cc: tarantool-patches
Hi, Igor!
Thanks for the patch! LGTM
On 7/12/23 21:06, Igor Munkin wrote:
> As a result of branch renaming in LuaJIT repository, the existing job
> concurrency group definition rule has become outdated. This patch
> updates the condition according to the new branch naming policy.
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>
> Branch: https://github.com/tarantool/luajit/tree/imun/ci-update-job-concurrency-group-def
>
> .github/workflows/exotic-builds-testing.yml | 12 +++++-------
> .github/workflows/gnumake-builds-testing.yml | 12 +++++-------
> .github/workflows/lint.yml | 12 +++++-------
> .github/workflows/testing.yml | 12 +++++-------
> 4 files changed, 20 insertions(+), 28 deletions(-)
>
> diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
> index 2269928f..318fb4dd 100644
> --- a/.github/workflows/exotic-builds-testing.yml
> +++ b/.github/workflows/exotic-builds-testing.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
> diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
> index b78823f1..afb96183 100644
> --- a/.github/workflows/gnumake-builds-testing.yml
> +++ b/.github/workflows/gnumake-builds-testing.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
> diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> index 71ceee9a..70c98104 100644
> --- a/.github/workflows/lint.yml
> +++ b/.github/workflows/lint.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
> diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> index 8300c443..2c637124 100644
> --- a/.github/workflows/testing.yml
> +++ b/.github/workflows/testing.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition
2023-07-12 18:06 [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition Igor Munkin via Tarantool-patches
2023-07-13 8:07 ` Sergey Kaplun via Tarantool-patches
2023-07-13 9:58 ` Sergey Bronnikov via Tarantool-patches
@ 2023-07-13 17:06 ` Igor Munkin via Tarantool-patches
2 siblings, 0 replies; 4+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2023-07-13 17:06 UTC (permalink / raw)
To: Sergey Kaplun, Sergey Bronnikov; +Cc: tarantool-patches
Pals, thanks for your reviews!
I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in tarantool/master,
tarantool/release/2.11 and tarantool/release/2.10.
On 12.07.23, Igor Munkin wrote:
> As a result of branch renaming in LuaJIT repository, the existing job
> concurrency group definition rule has become outdated. This patch
> updates the condition according to the new branch naming policy.
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>
> Branch: https://github.com/tarantool/luajit/tree/imun/ci-update-job-concurrency-group-def
>
> .github/workflows/exotic-builds-testing.yml | 12 +++++-------
> .github/workflows/gnumake-builds-testing.yml | 12 +++++-------
> .github/workflows/lint.yml | 12 +++++-------
> .github/workflows/testing.yml | 12 +++++-------
> 4 files changed, 20 insertions(+), 28 deletions(-)
>
<snipped>
> --
> 2.30.2
>
--
Best regards,
IM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-13 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-12 18:06 [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition Igor Munkin via Tarantool-patches
2023-07-13 8:07 ` Sergey Kaplun via Tarantool-patches
2023-07-13 9:58 ` Sergey Bronnikov via Tarantool-patches
2023-07-13 17:06 ` Igor Munkin via Tarantool-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox