From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: Maksim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Fix recording of union initialization.
Date: Thu, 13 Jul 2023 13:30:08 +0300 [thread overview]
Message-ID: <ZK/SMJSAIQYYu+e3@root> (raw)
In-Reply-To: <e5a8fd16-6633-4286-7ca9-398e9e2245ba@tarantool.org>
Hi, Maksim!
Thanks for the patch!
LGTM, after fixing the Sergey's comment regarding the test description.
On 13.07.23, Sergey Bronnikov wrote:
> Hi, Max!
>
>
> thanks for the patch!
>
> See my comments inline.
>
>
> Sergey
>
> On 7/10/23 18:56, Maksim Kokryashkin wrote:
> > From: Mike Pall <mike>
> >
> > Thanks to Alex Shpilkin.
> >
<snipped>
> > +for i = 1, NITERATIONS do
> > + test:ok(union_type(i).u == i)
> testcases description is missed, please add one.
> > +end
> > +
> > +os.exit(test:check() and 0 or 1)
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2023-07-13 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 15:56 Maksim Kokryashkin via Tarantool-patches
2023-07-13 9:26 ` Sergey Bronnikov via Tarantool-patches
2023-07-13 10:30 ` Sergey Kaplun via Tarantool-patches [this message]
2023-07-14 14:57 ` Maxim Kokryashkin via Tarantool-patches
2023-07-15 11:27 ` Sergey Kaplun via Tarantool-patches
2023-07-17 11:31 ` Maxim Kokryashkin via Tarantool-patches
2023-07-18 15:11 ` Sergey Bronnikov via Tarantool-patches
2023-07-20 18:37 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK/SMJSAIQYYu+e3@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] FFI: Fix recording of union initialization.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox