From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: split utils.lua into several modules
Date: Tue, 27 Jun 2023 13:35:45 +0000 [thread overview]
Message-ID: <ZJrlsemLEsx/l0+D@tarantool.org> (raw)
In-Reply-To: <b0d79e9b118f9a8444c9ff3dad6175519b0d5b86.1687872015.git.imun@tarantool.org>
A tiny fixup is coming...
On 27.06.23, Igor Munkin wrote:
> The next patch introduces a separate JIT-related module with convenient
> utils for JIT engine testing. Considering this change it looks vital to
> make a structured utils distributed module instead of "all in one" Lua
> chunk. As a result the original utils.lua is split into the several
> modules per subsystem to be tested (e.g. GC, frontend, profilers, etc.).
>
> Lazy loading of the introduced submodules allows to use this utils in
> all test chunks regardless LuaJIT configuration (e.g. with JIT engine
> disabled, without FFI support, etc) and do not spoil utils table with
> the excess helpers.
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
<snipped>
>
> diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
> index 527905b6..14a98cf2 100644
> --- a/test/tarantool-tests/CMakeLists.txt
> +++ b/test/tarantool-tests/CMakeLists.txt
> @@ -75,7 +75,7 @@ add_subdirectory(lj-flush-on-trace)
> # directory), so LUA_PATH need to be updated.
> make_lua_path(LUA_PATH
> PATHS
> - ${CMAKE_CURRENT_SOURCE_DIR}/?.lua
Oops, this line was removed by mistake: in this case tap.lua can't be
found. Removed this line back:
================================================================================
diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
index 14a98cf2..b1211971 100644
--- a/test/tarantool-tests/CMakeLists.txt
+++ b/test/tarantool-tests/CMakeLists.txt
@@ -75,6 +75,7 @@ add_subdirectory(lj-flush-on-trace)
# directory), so LUA_PATH need to be updated.
make_lua_path(LUA_PATH
PATHS
+ ${CMAKE_CURRENT_SOURCE_DIR}/?.lua
${CMAKE_CURRENT_SOURCE_DIR}/?/init.lua
${PROJECT_SOURCE_DIR}/tools/?.lua
${LUAJIT_SOURCE_DIR}/?.lua
================================================================================
> + ${CMAKE_CURRENT_SOURCE_DIR}/?/init.lua
> ${PROJECT_SOURCE_DIR}/tools/?.lua
> ${LUAJIT_SOURCE_DIR}/?.lua
> ${LUAJIT_BINARY_DIR}/?.lua
<snipped>
> --
> 2.30.2
>
--
Best regards,
IM
next prev parent reply other threads:[~2023-06-27 13:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 12:34 [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF Sergey Kaplun via Tarantool-patches
2023-05-10 12:34 ` [Tarantool-patches] [PATCH luajit 1/2] test: add utility for parsing `jit.dump` Sergey Kaplun via Tarantool-patches
2023-05-15 11:11 ` Maxim Kokryashkin via Tarantool-patches
2023-05-15 12:00 ` Maxim Kokryashkin via Tarantool-patches
2023-05-21 7:47 ` Sergey Kaplun via Tarantool-patches
2023-05-21 7:39 ` Sergey Kaplun via Tarantool-patches
2023-05-22 7:04 ` Sergey Kaplun via Tarantool-patches
2023-05-29 13:55 ` Maxim Kokryashkin via Tarantool-patches
2023-05-16 10:55 ` Sergey Bronnikov via Tarantool-patches
2023-05-22 7:02 ` Sergey Kaplun via Tarantool-patches
2023-05-22 9:14 ` Sergey Kaplun via Tarantool-patches
2023-05-10 12:34 ` [Tarantool-patches] [PATCH luajit 2/2] Fix canonicalization of +-0.0 keys for IR_NEWREF Sergey Kaplun via Tarantool-patches
2023-05-15 12:05 ` Maxim Kokryashkin via Tarantool-patches
2023-05-20 15:03 ` Sergey Kaplun via Tarantool-patches
2023-05-16 12:17 ` Sergey Bronnikov via Tarantool-patches
2023-05-20 14:54 ` Sergey Kaplun via Tarantool-patches
2023-05-22 7:55 ` Sergey Bronnikov via Tarantool-patches
2023-06-27 13:28 ` [Tarantool-patches] [PATCH luajit 1/3] test: split utils.lua into several modules Igor Munkin via Tarantool-patches
2023-06-27 13:35 ` Igor Munkin via Tarantool-patches [this message]
2023-06-28 11:36 ` Sergey Kaplun via Tarantool-patches
2023-06-28 16:07 ` Igor Munkin via Tarantool-patches
2023-07-04 17:10 ` [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJrlsemLEsx/l0+D@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/3] test: split utils.lua into several modules' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox