Re: [Tarantool-patches] [PATCH luajit v2] x64: Fix 64 bit shift code generation.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the fixes!
About the patch itself: just 2 typos in the comments to the test.

But I see [1] faliling tests on M1 with enabled JIT *.
May be related to the [2].
Anyway, good to see, that test shows something :).

*: I suggest to use `test:is()` instead of `test:ok()` to show `got`
`expected` values.

On 09.06.23, Maxim Kokryashkin wrote:
> From: Mike Pall <mike>

<snipped>

> +
> +for i = 1, NITERATIONS do
> +  -- Rotation is performed beyond the 32-bit size, for truncation

Typo: s/Rotation/The rotation/

> +  -- to become noticeable. Sprintf is used to ensure that the
> +  -- result of rotation goes into the `rcx`, corresponing to

Typo: s/corresponing/corresponding/

> +  -- the x86_64 ABI.

<snipped>

> -- 
> 2.40.1
> 

[1]: https://github.com/tarantool/luajit/actions/runs/5210890238/jobs/9402526109#step:7:907
[2]: https://github.com/tarantool/tarantool/issues/6097

-- 
Best regards,
Sergey Kaplun