From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2] x64: Fix 64 bit shift code generation. Date: Fri, 9 Jun 2023 12:50:39 +0300 [thread overview] Message-ID: <ZIL172eHXw7uKHx8@root> (raw) In-Reply-To: <20230609091358.1133736-1-m.kokryashkin@tarantool.org> Hi, Maxim! Thanks for the fixes! About the patch itself: just 2 typos in the comments to the test. But I see [1] faliling tests on M1 with enabled JIT *. May be related to the [2]. Anyway, good to see, that test shows something :). *: I suggest to use `test:is()` instead of `test:ok()` to show `got` `expected` values. On 09.06.23, Maxim Kokryashkin wrote: > From: Mike Pall <mike> <snipped> > + > +for i = 1, NITERATIONS do > + -- Rotation is performed beyond the 32-bit size, for truncation Typo: s/Rotation/The rotation/ > + -- to become noticeable. Sprintf is used to ensure that the > + -- result of rotation goes into the `rcx`, corresponing to Typo: s/corresponing/corresponding/ > + -- the x86_64 ABI. <snipped> > -- > 2.40.1 > [1]: https://github.com/tarantool/luajit/actions/runs/5210890238/jobs/9402526109#step:7:907 [2]: https://github.com/tarantool/tarantool/issues/6097 -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2023-06-09 9:54 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-09 9:13 Maxim Kokryashkin via Tarantool-patches 2023-06-09 9:50 ` Sergey Kaplun via Tarantool-patches [this message] 2023-06-13 12:42 Maxim Kokryashkin via Tarantool-patches 2023-06-28 10:57 ` Sergey Kaplun via Tarantool-patches 2023-06-29 8:59 ` Igor Munkin via Tarantool-patches 2023-07-04 17:09 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZIL172eHXw7uKHx8@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2] x64: Fix 64 bit shift code generation.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox