Re: [Tarantool-patches] [PATCH v2 luajit 2/6] test: introduce module for C tests

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!

On 29.05.23, Sergey Bronnikov wrote:
> This patch is LGTM after fixing typo below.
> 
> On 5/29/23 13:03, Sergey Kaplun wrote:
> >
> >>> ===================================================================
> >> This test checks that macroses/functions in test.h could be called and
> >> nothing more.
> >>
> >> We need checking TAP output that binary will emit for different test
> >> statuses, plan, testcase counters ("1..10").
> > As discussed offline: its not the main goal of this suite introducing,
> > also, TAP13 protocol is tested by `prove` itself, and fully compatible
> > with TAP14 protocol. Also, added the following check of parsing to be
> > sure in the emmited format correctness.
> >
> > ===================================================================
> > diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
> > index bf98856f..1aade851 100644
> > --- a/test/tarantool-c-tests/CMakeLists.txt
> > +++ b/test/tarantool-c-tests/CMakeLists.txt
> > @@ -36,6 +36,9 @@ add_custom_command(TARGET tarantool-c-tests
> >       ${CMAKE_CURRENT_BINARY_DIR}
> >       --ext ${C_TEST_SUFFIX}
> >       --jobs ${CMAKE_BUILD_PARALLEL_LEVEL}
> > +    # Reportt any TAP parse errors, if any, since test module is
> 
> Typo: Reportt -> Report

Fixed, thanks!

> 

<snipped>

> >

-- 
Best regards,
Sergey Kaplun