From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 353AA4912AA; Wed, 31 May 2023 16:36:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 353AA4912AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1685540208; bh=+8TdL2v084Do7V74Y7bOzcMgTEWaWLSM1Yk56idiHoM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lSVLBDZJiZ93zMsAj0Y/Al0nR+bO4ORqoFSBv3/mmfsGraJ7vWAl9PWV1cZyWc5tK z2rsqoiidFv3y4HFwveqIK3e79e3qQ8NguNBFcyYwY/PQs7Lbt9JGrHdF0r+ztw+XG x35vdPSpsouHwmD05u+SXfPyRl2n3p4PE2isqtbg= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [95.163.41.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C4D204912AA for ; Wed, 31 May 2023 16:36:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C4D204912AA Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1q4M0L-00GWkN-Sf; Wed, 31 May 2023 16:36:46 +0300 Date: Wed, 31 May 2023 16:32:37 +0300 To: Sergey Bronnikov Message-ID: References: <4564f805b390388473afa982db5cf3235f1cbaad.1684442182.git.skaplun@tarantool.org> <467c6552-2cc8-7097-6d86-bb8c9628bb84@tarantool.org> <1be152d0-9c74-0751-2473-2211ed32d625@tarantool.org> <367ae480-e546-697d-0269-9c081913f0ad@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <367ae480-e546-697d-0269-9c081913f0ad@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FA9FE7958A526B77F3EA8A7288154CF9F292A9D9E98E6BD200894C459B0CD1B92904E44CAC145CD6574DC3D181E375830CCC027DA3390114A41EFFA2D20C5292 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D77100FFB2844417EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637367CCE42412B8BE38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F4A1F5EDB4EA706B0E79F7D99E35B2BC117882F4460429728776938767073520CCD848CCB6FE560CF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F7F16001415B11694D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D88C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B5E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A58B085C479DA1948B1BC5FEB00C158775ED8E6DA728882F42F87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C75F910DBB8BE898B8557E169426DA08DA43AB6D534CBD0458C4267DC09168CCFB4714BCB0C6601C1D7E09C32AA3244C53901EF10CE52B764ABB65162DB3AC411DD47778AE04E04DBAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiEKym4lkdsvoTRCz2h8Rcg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76916DEC27F08C61FC9DC9B372523A4723FC479C2914A57FB1FDEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 2/6] test: introduce module for C tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 29.05.23, Sergey Bronnikov wrote: > This patch is LGTM after fixing typo below. > > On 5/29/23 13:03, Sergey Kaplun wrote: > > > >>> =================================================================== > >> This test checks that macroses/functions in test.h could be called and > >> nothing more. > >> > >> We need checking TAP output that binary will emit for different test > >> statuses, plan, testcase counters ("1..10"). > > As discussed offline: its not the main goal of this suite introducing, > > also, TAP13 protocol is tested by `prove` itself, and fully compatible > > with TAP14 protocol. Also, added the following check of parsing to be > > sure in the emmited format correctness. > > > > =================================================================== > > diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt > > index bf98856f..1aade851 100644 > > --- a/test/tarantool-c-tests/CMakeLists.txt > > +++ b/test/tarantool-c-tests/CMakeLists.txt > > @@ -36,6 +36,9 @@ add_custom_command(TARGET tarantool-c-tests > > ${CMAKE_CURRENT_BINARY_DIR} > > --ext ${C_TEST_SUFFIX} > > --jobs ${CMAKE_BUILD_PARALLEL_LEVEL} > > + # Reportt any TAP parse errors, if any, since test module is > > Typo: Reportt -> Report Fixed, thanks! > > > -- Best regards, Sergey Kaplun