Re: [Tarantool-patches] [PATCH v2 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!

On 22.05.23, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> Thanks for the patch. See one comment below.
> 
> On 5/18/23 23:44, Sergey Kaplun wrote:
> > When we set `LUA_TEST_ENV_MORE` variable to be used in the additional
> > env command for run testing if `"` is used to wrap the `LD_LIBRARY_PATH`
> > value the content of this environment variable is literally
> > `"/abs/path1:/abs/path2:...:"`. So, the first entry is treated as the
> > relative path starting with `"`. In that case if we need the library to
> > be loaded via FFI for this particular test, that loading fails with the
> > error "cannot open shared object file", since the path to it is
> > incorrect.
> >
> > This patch removes `"` wrapping for the aforementioned variables.
> > ---
> >   test/tarantool-tests/CMakeLists.txt | 9 +++++++--
> >   1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
> > index a428d009..38d6ae49 100644
> > --- a/test/tarantool-tests/CMakeLists.txt
> > +++ b/test/tarantool-tests/CMakeLists.txt
> > @@ -102,6 +102,11 @@ endif()
> >   # loaded modules on MacOS instead of shared libraries as it is
> >   # done on Linux and BSD, another environment variable should be
> >   # used to guide <ffi.load> while searching the extension.
> > +# XXX: Be noticed that we shouldn't use `"` here to wrap
> > +# the variable's content. If we do this, the variable value will
> > +# contain `"` at the beginning and the end, so this `"` at the
> > +# beginning will be treated as the directory for the first entry
> > +# (the last subdirectory added).
> >   if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> >     # XXX: Apple tries their best to "protect their users from
> >     # malware". As a result SIP (see the link[1] below) has been
> > @@ -122,9 +127,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> >     #
> >     # [1]: https://support.apple.com/en-us/HT204899
> >     # [2]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html
> > -  list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH="${LD_LIBRARY_PATH}")
> > +  list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH=${LD_LIBRARY_PATH})
> >   else()
> > -  list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")
> > +  list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH})
> 
> LUA_TEST_ENV_MORE  then will be passed to a shell for execution.
> 
> I suspect that command line execution will be broken when env variable 
> will contain non-escaped whitespaces.
> 
> It should be quoted or whitespaces should be escaped. So I propose to 
> escape whitespaces with backward slashes, see [1].

Yes, but we have some other problems with whitespaces already:

| Could not execute (/home/burii/reviews/luajit/dir\ space/src/luajit -e dofile[[/home/burii/reviews/luajit/dir;space/test/luajit-test-init.lua]] /home/burii/rev
| iews/luajit/dir): open3: exec of /home/burii/reviews/luajit/dir\ space/src/luajit -e dofile[[/home/burii/reviews/luajit/dir;space/test/luajit-test-init.lua]] /
| home/burii/reviews/luajit/dir failed: No such file or directory at /usr/lib64/perl5/5.34/TAP/Parser/Iterator/Process.pm line 165.

I suppose we can cover all such cases in the separate patchset.

> 
> 
> 1. 
> https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#how-can-i-get-quoting-and-escapes-to-work-properly
> 
> 
> >   endif()
> >   
> >   # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list

-- 
Best regards,
Sergey Kaplun