Re: [Tarantool-patches] [PATCH v2 luajit 5/6] test: rewrite misclib-sysprof-capi test in C

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!

On 19.05.23, Maxim Kokryashkin wrote:
> 
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for two questions below.
>  
> > 

<snipped>

> >>+
> >>+ lua_pushcfunction(L, c_payload);
> >>+ lua_setfield(L, LUA_GLOBALSINDEX, "c_payload");
> >Is there a cleaner approach?

I suppose no. I think that set the global value is the simpliest way for
this test.

> >>+ utils_load_aux_script(L);
> >>+
> >>+ const struct test_unit tgroup[] = {
> >>+ test_unit_new(base),
> >>+ test_unit_new(validation),
> >>+ test_unit_new(profile_func_jitoff),
> >>+ test_unit_new(profile_func_jiton)
> >Maybe we shouldn’t put these tests into group as long as they are disabled?

We still may skip them via TODO directive, so let them as is in the
output.

I'll wait for the 2nd review opinion and either use `#if 0` for comment
or double return.

> >>+ };
> >>+ const int test_result = test_run_group(tgroup, L);
> >>+ utils_lua_close(L);
> >>+ return test_result;
> >>+}
> >><snipped>
> >--
> >Best regards,
> >Maxim Kokryashkin
> > 

-- 
Best regards,
Sergey Kaplun