From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Make ASMREF_L references 64 bit. Date: Thu, 25 May 2023 06:16:33 +0000 [thread overview] Message-ID: <ZG79QZG0+qEpqQdM@tarantool.org> (raw) In-Reply-To: <20230411203650.10125-1-skaplun@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, 2.11 and 2.10. On 11.04.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall <mike> > > Reported by Yichun Zhang. > > (cherry picked from commit 850f8c59d3d04a9847f21f32a6c36d8269b5b6b1) > > The `ASMREF_L` reference is defined as `REF_NIL`, so it isn't considered > as 64 bit address. On GC64 mode it may lead to the following assembly: > | mov eax, edi > so, high 32 bits of the reference are lost. > > This patch adds `IRT_NIL` to `IRT_IS64` mask, to consider `ASMREF_L` > 64 bit long. Now the resulting assembly is the following: > | mov rax, rdi > > False-positive `if` condition in <src/lj_asm.c> is OK, since `op12` > already initialized as 0. > > False-positive `if` condition in <src/lj_opt_sink.c>, <src/lj_opt_split.c>, > <src/lj_record.c> is OK, since `REF_NIL` is the last reference before > `REF_BASE` and this iteration of a cycle is still the last one. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#8516 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/or-144-gc64-asmref-l > Related issues: > * https://github.com/openresty/lua-resty-core/issues/144 > * https://github.com/tarantool/tarantool/issues/8516 > PR: https://github.com/tarantool/tarantool/pull/8553 > ML: https://www.freelists.org/post/luajit/Consistent-SEGV-on-x64-with-the-latest-LuaJIT-v21-GC64-mode > > Don't restrict test case by GC64 mode, because want to test `IR_LREF` > for any mode. Keep GC64 in the test name, to be clear where expect the > SegFault. > > src/lj_asm.c | 1 + > src/lj_ir.h | 4 ++- > src/lj_opt_sink.c | 1 + > .../or-144-gc64-asmref-l.test.lua | 28 +++++++++++++++++++ > 4 files changed, 33 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/or-144-gc64-asmref-l.test.lua > <snipped> > -- > 2.34.1 > -- Best regards, IM
prev parent reply other threads:[~2023-05-25 6:19 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-11 20:36 Sergey Kaplun via Tarantool-patches 2023-04-18 16:33 ` Maxim Kokryashkin via Tarantool-patches 2023-05-02 8:13 ` Sergey Kaplun via Tarantool-patches 2023-05-03 8:32 ` sergos via Tarantool-patches 2023-05-03 8:40 ` Sergey Kaplun via Tarantool-patches 2023-05-03 8:56 ` Maxim Kokryashkin via Tarantool-patches 2023-05-25 6:16 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZG79QZG0+qEpqQdM@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Make ASMREF_L references 64 bit.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox