From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maksim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v4 4/4] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc. Date: Wed, 24 May 2023 06:10:13 +0000 [thread overview] Message-ID: <ZG2qRReDSzPvijwS@tarantool.org> (raw) In-Reply-To: <20230515091622.30232-5-max.kokryashkin@gmail.com> Max, Thanks for the patch! LGTM. BTW, the test description is neat, thanks! On 15.05.23, Maksim Kokryashkin wrote: > From: Mike Pall <mike> > > Reported by Victor Bombi, analyzed by XmiliaH. Thanks! > > (cherry-picked from commit bf51d3535109c4745bfbbe19a5587a9eac00259a) > > If the `snapalloc` flag is set, then the allocation has not > occurred yet, meaning that rename is applied to the next > snapshot. Otherwise, refs are already allocated and rename > is applied to the current snapshot. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#7745 > Part of tarantool/tarantool#8069 > --- > src/lj_asm.c | 9 ++- > .../lj-688-snap-ir-rename.test.lua | 60 +++++++++++++++++++ > 2 files changed, 68 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-688-snap-ir-rename.test.lua <snipped> > -- > 2.39.2 (Apple Git-143) > -- Best regards, IM
next prev parent reply other threads:[~2023-05-24 6:13 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-15 9:16 [Tarantool-patches] [PATCH luajit v4 0/4] jit: add exception unwinding Maksim Kokryashkin via Tarantool-patches 2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 1/4] Handle on-trace OOM errors from helper functions Maksim Kokryashkin via Tarantool-patches 2023-05-24 6:09 ` Igor Munkin via Tarantool-patches 2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 2/4] Disable unreliable assertion for external frame unwinding Maksim Kokryashkin via Tarantool-patches 2023-05-24 6:09 ` Igor Munkin via Tarantool-patches 2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 3/4] OSX: " Maksim Kokryashkin via Tarantool-patches 2023-05-24 6:10 ` Igor Munkin via Tarantool-patches 2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 4/4] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc Maksim Kokryashkin via Tarantool-patches 2023-05-24 6:10 ` Igor Munkin via Tarantool-patches [this message] 2023-05-22 9:27 ` [Tarantool-patches] [PATCH luajit v4 0/4] jit: add exception unwinding Sergey Kaplun via Tarantool-patches 2023-05-25 6:17 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZG2qRReDSzPvijwS@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit v4 4/4] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox