From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0A60E4695DD; Wed, 24 May 2023 09:13:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0A60E4695DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1684908831; bh=E3FI91edAcLsivFlWFIYeJOoo3ASdmhmzM82kK5XDlk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hR/HQVNz0wQzjC0P9MoZp614OCHQQF2nqOCnDsONO6lAz+VCgdnvBh1q635OIKT1H k7rI3B2wT3nkuS4nNxEzjJ/KMgAShtsGxpmpVR9V2y4gLNljzGoK9Zzd++uVIpg65p 4qCjKOedC0wUJmsNfXqxqfMP+qPh57inPPPY5wXI= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [95.163.41.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3037C4695D8 for ; Wed, 24 May 2023 09:13:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3037C4695D8 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1q1hk3-0079oM-5u; Wed, 24 May 2023 09:12:59 +0300 Date: Wed, 24 May 2023 06:10:13 +0000 To: Maksim Kokryashkin Message-ID: References: <20230515091622.30232-1-max.kokryashkin@gmail.com> <20230515091622.30232-5-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230515091622.30232-5-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9318AAE2601AA39B863B256D31290042D98EACC5A893CD50F00894C459B0CD1B92222C60FC2B2BC315C697B6AA8A2D45BEACB1E0530CB486C036170912EE13762 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C8BD49B17AF1FC7C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D842269DEA42DB2490B719C12489FBB3F6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC730D896219E5F9F4A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520D76C6ED7039589DE2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE38D4DC57D478E6889935A1E27F592749D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D886136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E6252A91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5CFD183422673C39689764E4CAF02AE9748854FFA0C2E5CE7F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF40FB2621EE2C2FE57DC7D0D692D77D2813FCCE579DB214A135C1E493621D698AC419EA6F1489DB16D5191E2618EE498C3B2D8CA6B82F3EB2168D39004C2B484654CE6006BCE07E73 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7RK+RruQK1evtNv8dXpYnA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531A62C2DAA4C0CE7745F72BA015915864CB7A3AAED7642DA122326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 4/4] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM. BTW, the test description is neat, thanks! On 15.05.23, Maksim Kokryashkin wrote: > From: Mike Pall > > Reported by Victor Bombi, analyzed by XmiliaH. Thanks! > > (cherry-picked from commit bf51d3535109c4745bfbbe19a5587a9eac00259a) > > If the `snapalloc` flag is set, then the allocation has not > occurred yet, meaning that rename is applied to the next > snapshot. Otherwise, refs are already allocated and rename > is applied to the current snapshot. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#7745 > Part of tarantool/tarantool#8069 > --- > src/lj_asm.c | 9 ++- > .../lj-688-snap-ir-rename.test.lua | 60 +++++++++++++++++++ > 2 files changed, 68 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-688-snap-ir-rename.test.lua > -- > 2.39.2 (Apple Git-143) > -- Best regards, IM