Re: [Tarantool-patches] [PATCH luajit v4 3/4] OSX: Disable unreliable assertion for external frame unwinding.

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

Thanks for the patch! LGTM with a single nit below.

On 15.05.23, Maksim Kokryashkin wrote:
> From: Mike Pall <mike>
> 
> (cherry-picked from commit be251d9149b386ca0d4b51106be14366c5dbdf14)
> 
> `_Unwind_Find_FDE()` will locate the FDE if the pc is in some
> function that has an associated FDE. Note, Mac OS X 10.6 and
> later, introduces "compact unwind info" which the runtime uses in
> preference to DWARF unwind info. This function will only work if
> the target function has an FDE but no compact unwind info.
> The LuaJIT VM produces compact unwind info entries, so

AFAIR, compact unwind info is generated only for machasm, isn't it? I
suggest to mention this explicitly in the commit message.

> DWARF's FDE is not found and that assertion fails.
> 
> Maxim Kokryashkin:
> * added the description for the problem
> 
> Part of tarantool/tarantool#7745
> Part of tarantool/tarantool#8069
> ---
>  src/lj_err.c | 3 +++
>  1 file changed, 3 insertions(+)

<snipped>

> -- 
> 2.39.2 (Apple Git-143)
> 

-- 
Best regards,
IM