From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maksim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v4 2/4] Disable unreliable assertion for external frame unwinding.
Date: Wed, 24 May 2023 06:09:44 +0000 [thread overview]
Message-ID: <ZG2qKIfq1BQV+wOj@tarantool.org> (raw)
In-Reply-To: <20230515091622.30232-3-max.kokryashkin@gmail.com>
Max,
Thanks for the patch! LGTM as trivial.
On 15.05.23, Maksim Kokryashkin wrote:
> From: Mike Pall <mike>
>
> Broken on Fedora/ARM64. Reported by Yichun Zhang.
>
> (cherry-picked from commit e957737650e060d5bf1c2909b741cc3dffe073ac)
>
> This patch disables the assertion that failed because of
> incorrectly constructed unwind information. That debug
> info generation was fixed in the scope of
> tarantool/tarantool#6096 with commit
> b731df1c0392cf7008be2e3c4112e1edb2392de4 ("ARM64: Reorder
> interpreter stack frame and fix unwinding.")
> This patch is backported only for consistency.
>
> Maxim Kokryashkin:
> * added the description for the problem
>
> Part of tarantool/tarantool#7745
> Part of tarantool/tarantool#8069
> Relates to tarantool/tarantool#6096
> ---
> src/lj_err.c | 2 ++
> 1 file changed, 2 insertions(+)
<snipped>
> --
> 2.39.2 (Apple Git-143)
>
--
Best regards,
IM
next prev parent reply other threads:[~2023-05-24 6:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 9:16 [Tarantool-patches] [PATCH luajit v4 0/4] jit: add exception unwinding Maksim Kokryashkin via Tarantool-patches
2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 1/4] Handle on-trace OOM errors from helper functions Maksim Kokryashkin via Tarantool-patches
2023-05-24 6:09 ` Igor Munkin via Tarantool-patches
2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 2/4] Disable unreliable assertion for external frame unwinding Maksim Kokryashkin via Tarantool-patches
2023-05-24 6:09 ` Igor Munkin via Tarantool-patches [this message]
2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 3/4] OSX: " Maksim Kokryashkin via Tarantool-patches
2023-05-24 6:10 ` Igor Munkin via Tarantool-patches
2023-05-15 9:16 ` [Tarantool-patches] [PATCH luajit v4 4/4] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc Maksim Kokryashkin via Tarantool-patches
2023-05-24 6:10 ` Igor Munkin via Tarantool-patches
2023-05-22 9:27 ` [Tarantool-patches] [PATCH luajit v4 0/4] jit: add exception unwinding Sergey Kaplun via Tarantool-patches
2023-05-25 6:17 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG2qKIfq1BQV+wOj@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit v4 2/4] Disable unreliable assertion for external frame unwinding.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox