From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergos <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Make ASMREF_L references 64 bit.
Date: Wed, 3 May 2023 11:40:01 +0300 [thread overview]
Message-ID: <ZFId4RJoz0DrBvPR@root> (raw)
In-Reply-To: <91DEE028-B10D-4B36-BBE2-FF18CE9AD514@tarantool.org>
Hi, Sergos!
Thanks for the review!
On 03.05.23, sergos wrote:
> Hi!
>
> Thanks for the patch!
>
> Since test is x86_64 only - can we put an explicit skipcond then?
We have two sides of the same coin here:
There is no bug for arm64, but some source code for this IR still
exists. Yes, we don't see any influence of the patch on arm64.
But, OTOH, we sure that there will be no regression in the future. As
far as changed code in the patch is platform independent, I prefer to
avoid skipcond here.
So, ignoring for now.
>
> Otherwise LGTM.
>
> Sergos.
>
<snipped>
>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2023-05-03 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 20:36 Sergey Kaplun via Tarantool-patches
2023-04-18 16:33 ` Maxim Kokryashkin via Tarantool-patches
2023-05-02 8:13 ` Sergey Kaplun via Tarantool-patches
2023-05-03 8:32 ` sergos via Tarantool-patches
2023-05-03 8:40 ` Sergey Kaplun via Tarantool-patches [this message]
2023-05-03 8:56 ` Maxim Kokryashkin via Tarantool-patches
2023-05-25 6:16 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFId4RJoz0DrBvPR@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Make ASMREF_L references 64 bit.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox