Re: [Tarantool-patches] [PATCH luajit v2 1/5] test: disable `lj-603-snap-restore` test

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the patch!
Please, consider my comment below.

On 14.03.23, Maxim Kokryashkin wrote:
> The test is extremely fragile and it is burdening
> to fix it in scope of every major change.
> ---
>  test/tarantool-tests/lj-603-err-snap-restore.test.lua | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/test/tarantool-tests/lj-603-err-snap-restore.test.lua b/test/tarantool-tests/lj-603-err-snap-restore.test.lua
> index 6eb53dfd..2f2eec7d 100644
> --- a/test/tarantool-tests/lj-603-err-snap-restore.test.lua
> +++ b/test/tarantool-tests/lj-603-err-snap-restore.test.lua
> @@ -2,7 +2,9 @@ local tap = require('tap')
>  -- Test to demonstrate the incorrect JIT behaviour when an error
>  -- is raised on restoration from the snapshot.
>  -- See also https://github.com/LuaJIT/LuaJIT/issues/603.
> -local test = tap.test('lj-603-err-snap-restore')
> +local test = tap.test('lj-603-err-snap-restore'):skipcond({
> +    ['Too fragile, temporarily disabled.'] = true
> +})

I've reverted your patch at the last commit (4d5e9afe) and everything
working just fine. I suggest to drop these changes.

>  
>  test:plan(2)
>  
> -- 
> 2.39.0
> 

-- 
Best regards,
Sergey Kaplun