From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/5] build: fix build with JIT disabled Date: Thu, 2 Mar 2023 15:52:17 +0000 [thread overview] Message-ID: <ZADGMXDeVoIMkmJX@tarantool.org> (raw) In-Reply-To: <1677698866.793685835@f426.i.mail.ru> Max, Thanks for your review! On 01.03.23, Maxim Kokryashkin wrote: > > Hi, Igor! > Thanks for the patch! > LGTM, except for a few nits reagrding the commit message. > > > > >>struct GCtrace is defined only if LJ_HASJIT is set. Hence, all spots > >Typo: s/struct GCtrace/`struct GCtrace` I can't remember whether I used this syntax in my commit messages. Furthermore, there is no strict rules in our guidelines regarding code references. Ignoring. > >>where GCtrace is used should be also moved under LJ_HASJIT define. > >Typo: s/should be also/should also be Fixed. > >> > >>Relates to tarantool/tarantool#8252 > >> > >>Signed-off-by: Igor Munkin < imun@tarantool.org > <snipped> > >-- > >Best regards, > >Maxim Kokryashkin > > -- Best regards, IM
next prev parent reply other threads:[~2023-03-02 15:55 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-28 19:00 [Tarantool-patches] [PATCH luajit v2 0/5] Adjust tests to be run when JIT is disabled Igor Munkin via Tarantool-patches 2023-02-28 19:00 ` [Tarantool-patches] [PATCH luajit v2 1/5] Minor fixes Igor Munkin via Tarantool-patches 2023-03-01 19:25 ` Maxim Kokryashkin via Tarantool-patches 2023-02-28 19:00 ` [Tarantool-patches] [PATCH luajit v2 2/5] build: fix build with JIT disabled Igor Munkin via Tarantool-patches 2023-03-01 19:27 ` Maxim Kokryashkin via Tarantool-patches 2023-03-02 15:52 ` Igor Munkin via Tarantool-patches [this message] 2023-02-28 19:00 ` [Tarantool-patches] [PATCH luajit v2 3/5] test: add skipcond for all JIT-related tests Igor Munkin via Tarantool-patches 2023-03-01 10:04 ` Sergey Kaplun via Tarantool-patches 2023-03-02 16:42 ` Igor Munkin via Tarantool-patches 2023-03-01 19:28 ` Maxim Kokryashkin via Tarantool-patches 2023-02-28 19:00 ` [Tarantool-patches] [PATCH luajit v2 4/5] test: fix lua-Harness " Igor Munkin via Tarantool-patches 2023-03-01 10:08 ` Sergey Kaplun via Tarantool-patches 2023-03-01 19:30 ` Maxim Kokryashkin via Tarantool-patches 2023-02-28 19:00 ` [Tarantool-patches] [PATCH luajit v2 5/5] ci: add nojit flavor for exotic builds Igor Munkin via Tarantool-patches 2023-03-01 19:30 ` Maxim Kokryashkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZADGMXDeVoIMkmJX@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2 2/5] build: fix build with JIT disabled' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox