From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 77D1821667F; Thu, 2 Mar 2023 18:55:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 77D1821667F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1677772528; bh=x9uj/x9tyfxTDkPTCZWsUmLrkNEWrAGQHQ1qb90zY2U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pOZqJPCTLHt/35vSAOBuT1y+VZt9tTfA7q+EpCacdEpoveDFdziLX6aboZP4Z7BDs wWpeoJSuMGKsQR03fdq28KqkkMeA0nfPH26S3MAh2lpIa09XBXEYtvWh/XRQFNJs3I ewcdUtUopWHT/vr/jikhFoXHdSVVmVH7fUOiGSZM= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F3D7C21667F for ; Thu, 2 Mar 2023 18:55:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F3D7C21667F Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1pXlHC-00F8x5-21; Thu, 02 Mar 2023 18:55:26 +0300 Date: Thu, 2 Mar 2023 15:52:17 +0000 To: Maxim Kokryashkin Message-ID: References: <1677698866.793685835@f426.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1677698866.793685835@f426.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9BCEC41593EBD8357C44FF2494EBC845BD7AEF656CFC8618A182A05F5380850408C7F75A34A37B74DA730FBB5249520CAB0678750FC31BB8D7CBE95DF361144BD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75C1B5DA09DAAC3CBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637670E1B164B70895C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DDF03C4A88BC976D128C76EAF946EF10117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC07EE6BD9D908E34E389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D72B8CFDDF92C982F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CC8D18BE04E21C490C0837EA9F3D197644AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3EAD86A1CE980672ABA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3457FA942CB4462B4C31E8C28B2BE2B39257B984CBEB1D1BCFFF5050505608E3D6218B7E10D07D20351D7E09C32AA3244CF01CF25C64CA65B8A7053A66D1AB152D33C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojpNlqDWxrEBYAV/vCWI37Lg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5313889787D1C9B2C4C10E05A696F3E263040F6B594272255222326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/5] build: fix build with JIT disabled X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for your review! On 01.03.23, Maxim Kokryashkin wrote: > > Hi, Igor! > Thanks for the patch! > LGTM, except for a few nits reagrding the commit message. >   > >  > >>struct GCtrace is defined only if LJ_HASJIT is set. Hence, all spots > >Typo: s/struct GCtrace/`struct GCtrace` I can't remember whether I used this syntax in my commit messages. Furthermore, there is no strict rules in our guidelines regarding code references. Ignoring. > >>where GCtrace is used should be also moved under LJ_HASJIT define. > >Typo: s/should be also/should also be Fixed. > >> > >>Relates to tarantool/tarantool#8252 > >> > >>Signed-off-by: Igor Munkin < imun@tarantool.org > > >-- > >Best regards, > >Maxim Kokryashkin > >  -- Best regards, IM