From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: unify helpers for a custom allocator setting
Date: Tue, 11 Mar 2025 15:38:50 +0300 [thread overview]
Message-ID: <Z9Au2pod4i-FrmM0@root> (raw)
In-Reply-To: <8ee07c5f-6326-4618-bc3f-247efa79c46a@tarantool.org>
Hi, Sergey!
Thanks for the review!
Fixed your comments and force-pushed the branch.
On 11.03.25, Sergey Bronnikov wrote:
> Hi, Sergey!
>
> Thanks for the patch! LGTM with two comments below.
>
> Feel free to ignore.
>
> Sergey
>
> On 10.03.2025 17:51, Sergey Kaplun wrote:
> > This patch merges two Lua C libraries that contain custom Lua allocators
> > with the injection of returning `NULL` into 1 library
> Minor: s/1/a single/
Fixed.
> > <utils/allocinject.c>. The new library contains 2 helpers:
> Minor: s/2/two/
Fixed.
> > * `enable_null_alloc()` -- returns `NULL` on every allocation (not
> > reallocation).
> > * `enable_null_doubling_realloc()` -- returns `NULL` on every
> > reallocation that doubles the size of the object. It can be useful for
> > testing corner cases, like OOM during IR/snapshot buffer reallocation
> > during trace recording.
> > The original allocator is returned via the `disable()` library function.
> >
> > The unified library helps to avoid code duplication and can be reused
> > for future tests.
> >
> > Needed for tarantool/tarantool#11055
> > ---
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2025-03-11 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 14:51 [Tarantool-patches] [PATCH luajit 0/3] Fixes for the concat metamethod Sergey Kaplun via Tarantool-patches
2025-03-10 14:51 ` [Tarantool-patches] [PATCH luajit 1/3] test: unify helpers for a custom allocator setting Sergey Kaplun via Tarantool-patches
2025-03-11 11:32 ` Sergey Bronnikov via Tarantool-patches
2025-03-11 12:38 ` Sergey Kaplun via Tarantool-patches [this message]
2025-03-11 14:45 ` Sergey Bronnikov via Tarantool-patches
2025-03-10 14:51 ` [Tarantool-patches] [PATCH luajit 2/3] Restore state when recording __concat metamethod throws OOM Sergey Kaplun via Tarantool-patches
2025-03-11 12:01 ` Sergey Bronnikov via Tarantool-patches
2025-03-11 12:37 ` Sergey Kaplun via Tarantool-patches
2025-03-11 14:46 ` Sergey Bronnikov via Tarantool-patches
2025-03-10 14:51 ` [Tarantool-patches] [PATCH luajit 3/3] Fix state restore when recording __concat metamethod Sergey Kaplun via Tarantool-patches
2025-03-12 7:53 ` Sergey Bronnikov via Tarantool-patches
2025-03-13 10:28 ` Sergey Kaplun via Tarantool-patches
2025-03-14 10:53 ` Sergey Bronnikov via Tarantool-patches
2025-03-26 8:55 ` [Tarantool-patches] [PATCH luajit 0/3] Fixes for the concat metamethod Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Au2pod4i-FrmM0@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/3] test: unify helpers for a custom allocator setting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox