Re: [Tarantool-patches] [PATCH luajit 8/8][v3] memprof: set default path to profiling output file

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the fixes!
LGTM, with a final nit below.

On 05.03.25, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> Updated and force-pushed.
> 
> Sergey
> 
> On 05.03.2025 13:57, Sergey Kaplun wrote:

<snipped>

> -  local _, _ = misc.memprof.start()
> -
> -  local res, err = misc.memprof.stop()
> +  local res, err = misc.memprof.start()
> +  -- Want to cleanup carefully if something went wrong.
> +  if not res then
> + test:fail('sysprof was not started: ' .. err)
> +    os.remove(default_output_file)
> +  end
> 
> +  res, err = misc.memprof.stop()
>     -- Want to cleanup carefully if something went wrong.
>     if not res then
> + test:fail('sysprof was not started: ' .. err)

Looks like it should be: "was not stopped successfully".

>       os.remove(default_output_file)
> -    error(err)
>     end
> 
> +
>     local profile_buf = tools.read_file(default_output_file)
> subtest:ok(profile_buf ~= nil and #profile_buf ~= 0,
>                'default output file is not empty')
> 
> -  -- We don't need it any more.
> +  -- We don't need it anymore.
>     os.remove(default_output_file)
>   end)
> 

<snipped>


-- 
Best regards,
Sergey Kaplun