Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix fix-mips64-spare-side-exit-patching
Date: Thu, 27 Feb 2025 19:05:04 +0300	[thread overview]
Message-ID: <Z8CNMOVRYrDvrDhw@root> (raw)
In-Reply-To: <39e85beb-f956-4359-9a40-016d855b0aa1@tarantool.org>

Hi, Sergey!
Thanks for the review!

On 27.02.25, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch!
> 
> On 27.02.2025 12:18, Sergey Kaplun wrote:
> > The aforementioned test is flaky when run under Tarantool due to not
> > enough room for all traces. The flushing of all traces at the start and
> > collecting them solves the issue.
> Have you considered another options like increasing `maxtrace` value?

We may also:
1) Increase the maxtrace value (as you are asking) -- but this is fragile,
since the number of built-in traces inside the Tarantool may grow up
again, so we should continuously adjust it in the future.
2) Disable the test for the Tarantool. Not so bad, but unnecessary --
since we may make the test platform-independent.

> > The same issue may occur for the
> > <gh-6098-fix-side-exit-patching-on-arm64.test.lua>, so it is adjusted as
> > well.
> > ---

<snipped>

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2025-02-27 16:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27  9:18 Sergey Kaplun via Tarantool-patches
2025-02-27 13:12 ` Sergey Bronnikov via Tarantool-patches
2025-02-27 16:05   ` Sergey Kaplun via Tarantool-patches [this message]
2025-02-28 13:12     ` Sergey Bronnikov via Tarantool-patches
2025-03-05  7:30 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8CNMOVRYrDvrDhw@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] test: fix fix-mips64-spare-side-exit-patching' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox