Re: [Tarantool-patches] [PATCH luajit 6/7] misc: specific message for disabled profilers

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the fixes!

On 19.02.25, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for review!
> 
> On 19.02.2025 11:06, Sergey Kaplun via Tarantool-patches wrote:

<snipped>

> > It's more LuaJIT-way to use something like the following:
> > | if (!LJ_HASSYSPROF) {
> > |   /* ... */
> > | }
> >
> > This helps to avoid strange early return.
> Fixed.
> > Also, please be avaired to declare all variables (stataus, opt,
> > err_details) in the beginning of the block.
> 
>   It is a requirement for the code that strictly follows c89, when you 
> must declare all of your variables at the beginning of a scope block.
> 
> AFAIK, we have no such requirement, and also there is no option 
> "-std=c89" in CI and no any mentions in the contribution guide.

This is not mentioned in Tarantool's contribution guide, since it is
LuaJIT-specific. In the perfect world, it should be checked by the flags
mentioned in <src/Makefile.original> (see the second CWARN).
Unfortunately, there are some bugs that should be fixed first.

<snipped>

-- 
Best regards,
Sergey Kaplun