From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <estetus@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 2/7] sysprof: align test title with test filename Date: Tue, 18 Feb 2025 14:10:12 +0300 [thread overview] Message-ID: <Z7RqlBVAaN9wuboj@root> (raw) In-Reply-To: <a4af169341660b4e2c1946afc9925f50dd8232b5.1739444510.git.sergeyb@tarantool.org> Hi, Sergey! Thanks fro the patch! LGTM, except a minor nits below. > sysprof: align test title with test filename It should be `test:`, since we don't change the sysprof component itself, only test for it. On 13.02.25, Sergey Bronnikov wrote: > The patch fixes TAP test title to make it aligned with test > filename. Inconsistency introduced in commit > efd7e1a67de24464e1e83793e16eac6df443e3c0 > ("test: make skipcond helper more convenient"). I am afraid that this naming was introduced in the first commit related to the tests (sysprof and memprof). > --- > test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 +- Should it be fixed for the memprof too? > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > index 237143ad..32fa384c 100644 > --- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > +++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua <snipped> > -- > 2.34.1 > -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2025-02-18 11:10 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-02-13 11:10 [Tarantool-patches] [PATCH luajit 0/7][v2] Fix profilers issues Sergey Bronnikov via Tarantool-patches 2025-02-13 11:10 ` [Tarantool-patches] [PATCH luajit 1/7][v2] test: add descriptions to sysprof testcases Sergey Bronnikov via Tarantool-patches 2025-02-18 11:04 ` Sergey Kaplun via Tarantool-patches 2025-02-13 11:10 ` [Tarantool-patches] [PATCH luajit 2/7] sysprof: align test title with test filename Sergey Bronnikov via Tarantool-patches 2025-02-18 11:10 ` Sergey Kaplun via Tarantool-patches [this message] 2025-02-18 14:02 ` Sergey Bronnikov via Tarantool-patches 2025-02-13 11:10 ` [Tarantool-patches] [PATCH luajit 3/7][v2] sysprof: fix typo in the comment Sergey Bronnikov via Tarantool-patches 2025-02-18 11:10 ` Sergey Kaplun via Tarantool-patches 2025-02-13 11:10 ` [Tarantool-patches] [PATCH luajit 4/7][v2] sysprof: introduce specific errors and default mode Sergey Bronnikov via Tarantool-patches 2025-02-18 15:43 ` Sergey Kaplun via Tarantool-patches 2025-02-19 9:34 ` Sergey Bronnikov via Tarantool-patches 2025-02-19 15:20 ` Sergey Kaplun via Tarantool-patches 2025-02-19 16:08 ` Sergey Bronnikov via Tarantool-patches 2025-02-13 11:10 ` [Tarantool-patches] [PATCH luajit 5/7] ci: add workflow with disabled profilers Sergey Bronnikov via Tarantool-patches 2025-02-18 12:10 ` Sergey Kaplun via Tarantool-patches 2025-02-18 14:14 ` Sergey Bronnikov via Tarantool-patches 2025-02-13 11:10 ` [Tarantool-patches] [PATCH luajit 6/7] misc: specific message for " Sergey Bronnikov via Tarantool-patches 2025-02-19 8:06 ` Sergey Kaplun via Tarantool-patches 2025-02-19 12:53 ` Sergey Bronnikov via Tarantool-patches 2025-02-19 15:41 ` Sergey Kaplun via Tarantool-patches 2025-02-19 15:56 ` Sergey Bronnikov via Tarantool-patches 2025-02-13 11:10 ` [Tarantool-patches] [PATCH luajit 7/7] memprof: set default path to profiling output file Sergey Bronnikov via Tarantool-patches 2025-02-18 11:55 ` Sergey Kaplun via Tarantool-patches 2025-02-18 14:20 ` Sergey Bronnikov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Z7RqlBVAaN9wuboj@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 2/7] sysprof: align test title with test filename' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox