From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix recording of BC_VARG.
Date: Mon, 10 Feb 2025 18:18:39 +0300 [thread overview]
Message-ID: <Z6oYz7RDVV6d8zET@root> (raw)
In-Reply-To: <3e8e566a-35ad-4895-89af-afbb67acd38e@tarantool.org>
Hi, Sergey!
Thanks for the review!
Fixed your comments and force-pushed the branch.
On 10.02.25, Sergey Bronnikov wrote:
> Hi, Sergey,
>
> thanks for the patch! LGTM with a minor comment.
>
> Sergey
>
> On 07.02.2025 16:05, Sergey Kaplun wrote:
>
>
> <snipped>
>
> > +jit.opt.start('hotloop=1')
> > +test:is(test_func(EXPECTED), EXPECTED, 'corect BC_VARG recording')
> Typo: "corect"
Fixed and force-pushed to the branch.
Also, rebased to the current master.
See the iterative patch below:
===================================================================
diff --git a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
index 20b43e07..b3a62b5c 100644
--- a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
+++ b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
@@ -31,6 +31,6 @@ local function test_func(...)
end
jit.opt.start('hotloop=1')
-test:is(test_func(EXPECTED), EXPECTED, 'corect BC_VARG recording')
+test:is(test_func(EXPECTED), EXPECTED, 'correct BC_VARG recording')
test:done(true)
===================================================================
> > +
> > +test:done(true)
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2025-02-10 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 13:05 Sergey Kaplun via Tarantool-patches
2025-02-10 15:14 ` Sergey Bronnikov via Tarantool-patches
2025-02-10 15:18 ` Sergey Kaplun via Tarantool-patches [this message]
2025-02-10 17:50 ` Sergey Bronnikov via Tarantool-patches
2025-02-13 10:51 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6oYz7RDVV6d8zET@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Fix recording of BC_VARG.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox