From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <estetus@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] sysprof: fix typo in the comment Date: Mon, 10 Feb 2025 17:51:32 +0300 [thread overview] Message-ID: <Z6oSdGtqeupqFb0B@root> (raw) In-Reply-To: <6ff0d573c1bc2302729c6c7e3b62a264f413b4f0.1738663201.git.sergeyb@tarantool.org> Hi, Sergey! Thanks for the patch! LGTM, with a few nits below regarding the commit message. On 04.02.25, Sergey Bronnikov wrote: > The patch fixes inconsistency in comment and source code below > the comment. The typo was added in the initial commit > 2593a9f83072 ("misc: introduce Lua API for new sampling profiler"). Please use the full commit hash. I know that this is enough too, but: a) It would be consistent with other commit messages. b) There is less probability of the collision between hashes. Maybe it is worth to mention "Follows up tarantool/tarantool#781" (the sysprof ticket) if you want (I am not sure that this is needed, since it is only the comment). > --- > src/lib_misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib_misc.c b/src/lib_misc.c > index ca1d1c75..5b7a4b62 100644 > --- a/src/lib_misc.c > +++ b/src/lib_misc.c <snipped> > -- > 2.34.1 > -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2025-02-10 14:52 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-02-04 10:03 [Tarantool-patches] [PATCH luajit 0/4] Fix sysprof issues Sergey Bronnikov via Tarantool-patches 2025-02-04 10:03 ` [Tarantool-patches] [PATCH luajit 1/4] test: add descriptions to sysprof testcases Sergey Bronnikov via Tarantool-patches 2025-02-10 14:51 ` Sergey Kaplun via Tarantool-patches 2025-02-11 8:16 ` Sergey Bronnikov via Tarantool-patches 2025-02-04 10:03 ` [Tarantool-patches] [PATCH luajit 2/4] sysprof: fix typo in the comment Sergey Bronnikov via Tarantool-patches 2025-02-10 14:51 ` Sergey Kaplun via Tarantool-patches [this message] 2025-02-11 8:21 ` Sergey Bronnikov via Tarantool-patches 2025-02-04 10:03 ` [Tarantool-patches] [PATCH luajit 3/4] sysprof: introduce specific errors and default mode Sergey Bronnikov via Tarantool-patches 2025-02-10 14:51 ` Sergey Kaplun via Tarantool-patches 2025-02-13 11:14 ` Sergey Bronnikov via Tarantool-patches 2025-02-04 10:03 ` [Tarantool-patches] [PATCH luajit 4/4] sysprof: fix a message with stop without run Sergey Bronnikov via Tarantool-patches 2025-02-10 14:52 ` Sergey Kaplun via Tarantool-patches 2025-02-11 9:49 ` Sergey Bronnikov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Z6oSdGtqeupqFb0B@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 2/4] sysprof: fix typo in the comment' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox