From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: Sergey Bronnikov <estetus@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Handle all stack layouts in (delayed) TRACE vmevent.
Date: Fri, 7 Feb 2025 13:49:54 +0300 [thread overview]
Message-ID: <Z6XlUsKqu92__8fL@root> (raw)
In-Reply-To: <16d60884-cb3b-42c5-ab66-b20bf769b750@tarantool.org>
Hi, Sergey!
Thanks for the fixes and the answers.
On 05.02.25, Sergey Bronnikov wrote:
<snipped>
> >> + lua_pushcfunction(L, (lua_CFunction)cb);
> >> + if (event != NULL) {
> > Nit: Brackets are excess.
> > Feel free to ignore.
>
> Removed, anyway it is a test code and without braces it looks more clean.
>
> However, I'm always enclosing statements in loop/if/else in braces,
>
> because I remember about "goto fail" issue [1].
>
> 1. https://dwheeler.com/essays/apple-goto-fail.html
Side note: I believe that the reason here is not the goto `usage` or
code without braces. But this is more like a philosophic question to
discuss. :)
--
Best regards,
Sergey Kaplun
prev parent reply other threads:[~2025-02-07 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 9:46 Sergey Bronnikov via Tarantool-patches
2025-02-05 9:48 ` Sergey Kaplun via Tarantool-patches
2025-02-05 14:32 ` Sergey Bronnikov via Tarantool-patches
2025-02-07 10:49 ` Sergey Kaplun via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6XlUsKqu92__8fL@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Handle all stack layouts in (delayed) TRACE vmevent.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox