From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: Sergey Bronnikov <estetus@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit][v2] test: limit code and comment max length
Date: Fri, 14 Feb 2025 18:35:34 +0300 [thread overview]
Message-ID: <Z69ixp2O9P_sZVUh@root> (raw)
In-Reply-To: <18776d28-113c-44ac-8c8a-b1966f4ea2f5@tarantool.org>
Hi, Sergey!
LGTM!
I've also aplied the following patch to your branch after rebase on
the current tarantool/master:
===================================================================
diff --git a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
index b3a62b5c..f4d222f9 100644
--- a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
+++ b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
@@ -1,8 +1,12 @@
local tap = require('tap')
+-- luacheck: push no max_comment_line_length
+--
-- Test file to demonstrate incorrect recording of `BC_VARG` that
-- is given to the `select()` function. See also:
-- https://www.freelists.org/post/luajit/Possible-issue-during-register-allocation-ra-alloc1.
+--
+-- luacheck: pop
local test = tap.test('fix-recording-bc-varg-used-in-select'):skipcond({
['Test requires JIT enabled'] = not jit.status(),
===================================================================
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2025-02-14 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 12:16 Sergey Bronnikov via Tarantool-patches
2025-02-13 13:50 ` Sergey Kaplun via Tarantool-patches
2025-02-14 6:49 ` Sergey Bronnikov via Tarantool-patches
2025-02-14 15:35 ` Sergey Kaplun via Tarantool-patches [this message]
2025-03-05 7:29 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z69ixp2O9P_sZVUh@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit][v2] test: limit code and comment max length' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox