Re: [Tarantool-patches] [PATCH v3 luajit] Fix command-line argv handling.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 28.01.25, Sergey Bronnikov wrote:
> Sergey,
> 
> 
> thanks for the patch! LGTM with a minor comment.
> 
> Sergey
> 
> On 27.01.2025 13:18, Sergey Kaplun wrote:
> 
> 
> <snipped>
> 
> > diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
> > index c4a402d0..c84c651d 100644
> > --- a/test/tarantool-c-tests/CMakeLists.txt
> > +++ b/test/tarantool-c-tests/CMakeLists.txt
> > @@ -41,6 +41,14 @@ file(GLOB tests "${CMAKE_CURRENT_SOURCE_DIR}/*${CTEST_SRC_SUFFIX}")
> >   foreach(test_source ${tests})
> >     # Get test name without suffix. Needed to set OUTPUT_NAME.
> >     get_filename_component(exe ${test_source} NAME_WE)
> > +
> > +  # Test requires static build, since it inspects internal
> > +  # symbols.
> > +  if(exe STREQUAL "gh-8594-sysprof-ffunc-crash"
> > +      AND BUILDMODE STREQUAL "dynamic")
> please put AND to the previous line and fix indentation
> <snipped>

Fixed, thanks!

===================================================================
diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
index c84c651d..32a8add0 100644
--- a/test/tarantool-c-tests/CMakeLists.txt
+++ b/test/tarantool-c-tests/CMakeLists.txt
@@ -44,8 +44,8 @@ foreach(test_source ${tests})
 
   # Test requires static build, since it inspects internal
   # symbols.
-  if(exe STREQUAL "gh-8594-sysprof-ffunc-crash"
-      AND BUILDMODE STREQUAL "dynamic")
+  if(exe STREQUAL "gh-8594-sysprof-ffunc-crash" AND
+     BUILDMODE STREQUAL "dynamic")
     continue()
   endif()
 
===================================================================


-- 
Best regards,
Sergey Kaplun