[Tarantool-patches] [PATCH luajit] test: fix Clang warning in LuaJIT-tests

[Tarantool-patches] [PATCH luajit] test: fix Clang warning in LuaJIT-tests

[Sergey Kaplun via Tarantool-patches]

This patch fixes the warning in <libctest.c> produced by Clang:
| warning: plain '_Complex' requires a type specifier; assuming
| '_Complex double'
by adding the `double` type specifier where it is needed.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-test-complex-double

 test/LuaJIT-tests/src/libctest.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/LuaJIT-tests/src/libctest.c b/test/LuaJIT-tests/src/libctest.c
index aa95b57b..955383d7 100644
--- a/test/LuaJIT-tests/src/libctest.c
+++ b/test/LuaJIT-tests/src/libctest.c
@@ -73,9 +73,9 @@ LUA_API double call_ividi(int a, ...)
 }
 
 #ifdef complex
-LUA_API complex call_dd_cd(double a, double b) { return a+b*2i; }
-LUA_API complex call_cd(complex a) { return a+1-2i; }
-LUA_API complex call_cdcd(complex a, complex b) { return a+b; }
+LUA_API complex double call_dd_cd(double a, double b) { return a+b*2i; }
+LUA_API complex double call_cd(complex double a) { return a+1-2i; }
+LUA_API complex double call_cdcd(complex double a, complex double b) { return a+b; }
 
 LUA_API complex float call_ff_cf(float a, float b) { return a+b*2i; }
 LUA_API complex float call_cf(complex float a) { return a+1-2i; }
-- 
2.47.0

Re: [Tarantool-patches] [PATCH luajit] test: fix Clang warning in LuaJIT-tests

[Sergey Bronnikov via Tarantool-patches]

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

Hi, Sergey

thanks for the patch! LGTM

On 19.11.2024 13:58, Sergey Kaplun wrote:
> This patch fixes the warning in <libctest.c> produced by Clang:
> | warning: plain '_Complex' requires a type specifier; assuming
> | '_Complex double'
> by adding the `double` type specifier where it is needed.
> ---
>
> Branch:https://github.com/tarantool/luajit/tree/skaplun/fix-test-complex-double
>
>   test/LuaJIT-tests/src/libctest.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/LuaJIT-tests/src/libctest.c b/test/LuaJIT-tests/src/libctest.c
> index aa95b57b..955383d7 100644
> --- a/test/LuaJIT-tests/src/libctest.c
> +++ b/test/LuaJIT-tests/src/libctest.c
> @@ -73,9 +73,9 @@ LUA_API double call_ividi(int a, ...)
>   }
>   
>   #ifdef complex
> -LUA_API complex call_dd_cd(double a, double b) { return a+b*2i; }
> -LUA_API complex call_cd(complex a) { return a+1-2i; }
> -LUA_API complex call_cdcd(complex a, complex b) { return a+b; }
> +LUA_API complex double call_dd_cd(double a, double b) { return a+b*2i; }
> +LUA_API complex double call_cd(complex double a) { return a+1-2i; }
> +LUA_API complex double call_cdcd(complex double a, complex double b) { return a+b; }
>   
>   LUA_API complex float call_ff_cf(float a, float b) { return a+b*2i; }
>   LUA_API complex float call_cf(complex float a) { return a+1-2i; }

[-- Attachment #2: Type: text/html, Size: 1884 bytes --]

Re: [Tarantool-patches] [PATCH luajit] test: fix Clang warning in LuaJIT-tests

[Maxim Kokryashkin via Tarantool-patches]

Hi, Sergey!
Thanks for the patch!
LGTM

Re: [Tarantool-patches] [PATCH luajit] test: fix Clang warning in LuaJIT-tests

[Sergey Kaplun via Tarantool-patches]

I've applied the patch into all long-term branches in tarantool/luajit
and bumped a new version in master [1], release/3.3 [2], release/3.2 [3]
and release/2.11 [4].

[1]: https://github.com/tarantool/tarantool/pull/10936
[2]: https://github.com/tarantool/tarantool/pull/10937
[3]: https://github.com/tarantool/tarantool/pull/10938
[4]: https://github.com/tarantool/tarantool/pull/10939

-- 
Best regards,
Sergey Kaplun