From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash
Date: Fri, 6 Dec 2024 10:55:49 +0300 [thread overview]
Message-ID: <Z1KuBa8WzG0h9KyW@root> (raw)
In-Reply-To: <7f150753add9e09fd2285ccaa7c70e6a6dc949ab.1733468484.git.sergeyb@tarantool.org>
Hi, Sergey!
Thanks for the patch!
LGTM, with a few nits regarding the commit message.
On 06.12.24, Sergey Bronnikov wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> - fix a typo in a comment
Typo? /fix/Fix/
Typo? /comment/comment./
> - replace `skip_all()` with `skip()` because it is strange
Typo? /replace/Replace/
> to skip overall test group inside a testcase.
Typo: s/overall test group/the overall test group/
> ---
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2024-12-06 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 7:05 [Tarantool-patches] [PATCH luajit 0/2] Respect LUAJIT_DISABLE_SYSPROF in sysprof tests Sergey Bronnikov via Tarantool-patches
2024-12-06 7:06 ` [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash Sergey Bronnikov via Tarantool-patches
2024-12-06 7:55 ` Sergey Kaplun via Tarantool-patches [this message]
2024-12-06 10:16 ` Sergey Bronnikov via Tarantool-patches
2024-12-11 12:24 ` Maxim Kokryashkin via Tarantool-patches
2024-12-06 7:06 ` [Tarantool-patches] [PATCH luajit 2/2] test: skip sysprof tests with LUAJIT_DISABLE_SYSPROF Sergey Bronnikov via Tarantool-patches
2024-12-06 8:08 ` Sergey Kaplun via Tarantool-patches
2024-12-06 10:31 ` Sergey Bronnikov via Tarantool-patches
2024-12-11 12:25 ` Maxim Kokryashkin via Tarantool-patches
2024-12-17 12:23 ` [Tarantool-patches] [PATCH luajit 0/2] Respect LUAJIT_DISABLE_SYSPROF in sysprof tests Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1KuBa8WzG0h9KyW@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox