[Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Sergey Kaplun via Tarantool-patches]

This patch fixes the typo 'snapshoting' -> 'snapshotting' in the
<lj-736-BC_UCLO-triggers-infinite-loop.test.lua>.
Also, it adds `tru` and `fal` to the ignore list since they are used in
the LuaJIT JIT dump output.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-no-ticket-codespell-2.3.0-fixes
Note: CI is red due-to integrational testing problems.
See https://github.com/tarantool/tarantool/pull/11220.

 .codespell-ignore-words.txt                                | 2 ++
 .../lj-736-BC_UCLO-triggers-infinite-loop.test.lua         | 7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
index 757ee53d..1fcceefa 100644
--- a/.codespell-ignore-words.txt
+++ b/.codespell-ignore-words.txt
@@ -1,3 +1,5 @@
+fal
 fpr
 isnt
 nd
+tru
diff --git a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
index 01dba4bb..3f22c203 100644
--- a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
+++ b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
@@ -35,9 +35,10 @@ local function testcase()
 
     -- Records the trace for which use-def analysis is applied.
     for i = 1, 2 do
-      -- This condition triggers snapshoting and use-def analysis.
-      -- Before the patch this triggers the infinite loop in the
-      -- `snap_usedef()`, so the `goto` is never taken.
+      -- This condition triggers snapshotting and use-def
+      -- analysis. Before the patch this triggers the infinite
+      -- loop in the `snap_usedef()`, so the `goto` is never
+      -- taken.
       if i == 2 then
         goto x
       end
-- 
2.48.1

Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Sergey Bronnikov via Tarantool-patches]

[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]

Hi, Sergey

LGTM

On 10.03.2025 17:42, Sergey Kaplun wrote:
> This patch fixes the typo 'snapshoting' -> 'snapshotting' in the
> <lj-736-BC_UCLO-triggers-infinite-loop.test.lua>.
> Also, it adds `tru` and `fal` to the ignore list since they are used in
> the LuaJIT JIT dump output.
> ---
>
> Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-no-ticket-codespell-2.3.0-fixes
> Note: CI is red due-to integrational testing problems.
> Seehttps://github.com/tarantool/tarantool/pull/11220.
>
>   .codespell-ignore-words.txt                                | 2 ++
>   .../lj-736-BC_UCLO-triggers-infinite-loop.test.lua         | 7 ++++---
>   2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
> index 757ee53d..1fcceefa 100644
> --- a/.codespell-ignore-words.txt
> +++ b/.codespell-ignore-words.txt
> @@ -1,3 +1,5 @@
> +fal
>   fpr
>   isnt
>   nd
> +tru
> diff --git a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
> index 01dba4bb..3f22c203 100644
> --- a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
> +++ b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
> @@ -35,9 +35,10 @@ local function testcase()
>   
>       -- Records the trace for which use-def analysis is applied.
>       for i = 1, 2 do
> -      -- This condition triggers snapshoting and use-def analysis.
> -      -- Before the patch this triggers the infinite loop in the
> -      -- `snap_usedef()`, so the `goto` is never taken.
> +      -- This condition triggers snapshotting and use-def
> +      -- analysis. Before the patch this triggers the infinite
> +      -- loop in the `snap_usedef()`, so the `goto` is never
> +      -- taken.
>         if i == 2 then
>           goto x
>         end

[-- Attachment #2: Type: text/html, Size: 2489 bytes --]

Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Sergey Bronnikov via Tarantool-patches]

[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]

Please also bump codespell version in .github/workflows/lint.yml.

On 11.03.2025 14:13, Sergey Bronnikov via Tarantool-patches wrote:
>
> Hi, Sergey
>
> LGTM
>
> On 10.03.2025 17:42, Sergey Kaplun wrote:
>> This patch fixes the typo 'snapshoting' -> 'snapshotting' in the
>> <lj-736-BC_UCLO-triggers-infinite-loop.test.lua>.
>> Also, it adds `tru` and `fal` to the ignore list since they are used in
>> the LuaJIT JIT dump output.
>> ---
>>
>> Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-no-ticket-codespell-2.3.0-fixes
>> Note: CI is red due-to integrational testing problems.
>> Seehttps://github.com/tarantool/tarantool/pull/11220.
>>
>>   .codespell-ignore-words.txt                                | 2 ++
>>   .../lj-736-BC_UCLO-triggers-infinite-loop.test.lua         | 7 ++++---
>>   2 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
>> index 757ee53d..1fcceefa 100644
>> --- a/.codespell-ignore-words.txt
>> +++ b/.codespell-ignore-words.txt
>> @@ -1,3 +1,5 @@
>> +fal
>>   fpr
>>   isnt
>>   nd
>> +tru
>> diff --git a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
>> index 01dba4bb..3f22c203 100644
>> --- a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
>> +++ b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
>> @@ -35,9 +35,10 @@ local function testcase()
>>   
>>       -- Records the trace for which use-def analysis is applied.
>>       for i = 1, 2 do
>> -      -- This condition triggers snapshoting and use-def analysis.
>> -      -- Before the patch this triggers the infinite loop in the
>> -      -- `snap_usedef()`, so the `goto` is never taken.
>> +      -- This condition triggers snapshotting and use-def
>> +      -- analysis. Before the patch this triggers the infinite
>> +      -- loop in the `snap_usedef()`, so the `goto` is never
>> +      -- taken.
>>         if i == 2 then
>>           goto x
>>         end

[-- Attachment #2: Type: text/html, Size: 2979 bytes --]

Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Sergey Kaplun via Tarantool-patches]

Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.
See the corresponding run:
https://github.com/tarantool/luajit/actions/runs/13925861146/job/38970063708#step:4:63

On 12.03.25, Sergey Bronnikov wrote:
> Please also bump codespell version in .github/workflows/lint.yml.

Bumped:

===================================================================
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 85e1b646..b0fb83eb 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -44,7 +44,7 @@ jobs:
           sudo apt -y install cmake ninja-build lua5.1 luarocks
           sudo luarocks install luacheck
           sudo pip3 install flake8==6.1.0
-          sudo pip3 install codespell==2.2.5
+          sudo pip3 install codespell==2.3.0
           # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to
           # limit the number of parallel jobs for build/test step.
           echo CMAKE_BUILD_PARALLEL_LEVEL=$(($(nproc) + 1)) | tee -a $GITHUB_ENV
===================================================================

> 
> On 11.03.2025 14:13, Sergey Bronnikov via Tarantool-patches wrote:

<snipped>

-- 
Best regards,
Sergey Kaplun

Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Sergey Bronnikov via Tarantool-patches]

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

Nice! LGTM

On 18.03.2025 17:36, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed your comment and force-pushed the branch.
> See the corresponding run:
> https://github.com/tarantool/luajit/actions/runs/13925861146/job/38970063708#step:4:63
>
> On 12.03.25, Sergey Bronnikov wrote:
>> Please also bump codespell version in .github/workflows/lint.yml.
> Bumped:
>
> ===================================================================
> diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> index 85e1b646..b0fb83eb 100644
> --- a/.github/workflows/lint.yml
> +++ b/.github/workflows/lint.yml
> @@ -44,7 +44,7 @@ jobs:
>             sudo apt -y install cmake ninja-build lua5.1 luarocks
>             sudo luarocks install luacheck
>             sudo pip3 install flake8==6.1.0
> -          sudo pip3 install codespell==2.2.5
> +          sudo pip3 install codespell==2.3.0
>             # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to
>             # limit the number of parallel jobs for build/test step.
>             echo CMAKE_BUILD_PARALLEL_LEVEL=$(($(nproc) + 1)) | tee -a $GITHUB_ENV
> ===================================================================
>
>> On 11.03.2025 14:13, Sergey Bronnikov via Tarantool-patches wrote:
> <snipped>
>

[-- Attachment #2: Type: text/html, Size: 2096 bytes --]

Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Sergey Kaplun via Tarantool-patches]

I've applied the patch into all long-term branches in tarantool/luajit
and bumped a new version in master [1], release/3.3 [2], release/3.2 [3]
and release/2.11 [4].

[1]: https://github.com/tarantool/tarantool/pull/11281
[2]: https://github.com/tarantool/tarantool/pull/11282
[3]: https://github.com/tarantool/tarantool/pull/11283
[4]: https://github.com/tarantool/tarantool/pull/11284

-- 
Best regards,
Sergey Kaplun