Re: [Tarantool-patches] [PATCH luajit 2/6] OSX: Fix build by hardcoding external frame unwinding.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maksim!

Thanks for the patch!
LGTM with bunch of comments below.

On 26.09.22, Maksim Kokryashkin wrote:
> Apparently they can't even get 'grep' right, let alone a keyboard.
> 
> (cherry picked from commit d4a554d6ee1507f7313641b26ed09bf1b518fa1f)
> 
> MacOS uses BSD grep, which is slightly different from GNU grep.
> Because of that, the shell script determining whether external
> unwinding is possible doesn't work right.

Nit: It detects, that unwinding is impossible, when it is possible
actually. So we can mention here, that scripts yields false negative
result for MacOS.

> 
> External unwinding is possible on MacOS, so this patch enables

I suggest to write here "always possible" to clarify the sentence.

> it by default.
> 
> Maxim Kokryashkin:
> * added the description for the problem
> 
> Needed for tarantool/tarantool#6096
> Needed for tarantool/tarantool#7230

I suggest to replace the line above with:

| Part of tarantool/tarantool#7230

(Forgot to mention this in the previous patch, so it should be done for
the previous commit too.)

> ---
>  .github/workflows/macos-x86_64.yml | 20 +-------------------

Looks like this fixes should be done in the previous commit.

>  cmake/SetTargetFlags.cmake         | 28 ++++++++++++++++------------
>  src/Makefile.original              | 15 ++++++++-------
>  3 files changed, 25 insertions(+), 38 deletions(-)
> 
> diff --git a/.github/workflows/macos-x86_64.yml b/.github/workflows/macos-x86_64.yml
> index 840806e3..dafd1796 100644
> --- a/.github/workflows/macos-x86_64.yml
> +++ b/.github/workflows/macos-x86_64.yml

<snipped>

> diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
> index 36896aff..a5a3407f 100644
> --- a/cmake/SetTargetFlags.cmake
> +++ b/cmake/SetTargetFlags.cmake

<snipped>

> diff --git a/src/Makefile.original b/src/Makefile.original
> index c9609700..d1373b40 100644
> --- a/src/Makefile.original
> +++ b/src/Makefile.original

<snipped>

> -- 
> 2.32.1 (Apple Git-133)
> 

-- 
Best regards,
Sergey Kaplun