Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Igor!

Thanks for the patch!
LGTM, except a single nit below.

Also, I suppose that the test will be added in the Tarantool patch with
version bump, as far as this option will be enabled by default for
Tarantool build.
Am I right?

On 02.10.22, Igor Munkin wrote:
> Originally there is nether a special option nor a variable to configure
> check for instrunction/line hooks for compiled code via the build system

Typo: s/check/the check/

> being used. We finally decided to use this feature in Tarantool, so for
> convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root
> project CMakeLists.txt.
> 
> Needed for tarantool/tarantool#7762
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/7762
> Branch: https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook
> CI: https://github.com/tarantool/luajit/commit/701de8c
> 
>  CMakeLists.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 8b49f9d7..c870cce2 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt

<snipped>

> -- 
> 2.34.0
> 

-- 
Best regards,
Sergey Kaplun