From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: Maksim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2] Fix narrowing of unary minus.
Date: Thu, 29 Sep 2022 16:08:35 +0300 [thread overview]
Message-ID: <YzWY05XuuRoy4Uds@root> (raw)
In-Reply-To: <1664445487.810639758@f460.i.mail.ru>
Hi, Maxim!
Thanks for the fixes!
LGTM, just a single nit below.
On 29.09.22, Maxim Kokryashkin via Tarantool-patches wrote:
>
> Hi, Sergos!
> Thanks for the questions!
> Please consider my answers amd changes below.
<snipped>
> Here is the diff:
> ===============================================
> --- a/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua
> +++ b/test/tarantool-tests/gh-6976-narrowing-of-unary-minus.test.lua
<snipped>
> +test:ok(check(function()
> + -- See the comment about `table.new()` above.
> + local res = require('table.new')(3, 0)
> + for i = 2, 0, -1 do
> + table.insert(res, 1 / -i)
> + end
> + return res
> +end),'assertion guard fail')
Typo: s/,/, /
>
<snipped>
> Best regards,
> Maxim Kokryashkin
>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2022-09-29 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 12:15 [Tarantool-patches] [PATCH luajit] " Maksim Kokryashkin via Tarantool-patches
2022-09-14 22:06 ` Sergey Kaplun via Tarantool-patches
2022-09-20 11:16 ` [Tarantool-patches] [PATCH luajit v2] " Maksim Kokryashkin via Tarantool-patches
2022-09-21 8:48 ` Sergey Kaplun via Tarantool-patches
2022-09-25 21:31 ` sergos via Tarantool-patches
2022-09-29 9:58 ` Maxim Kokryashkin via Tarantool-patches
2022-09-29 13:08 ` Sergey Kaplun via Tarantool-patches [this message]
2022-10-03 9:57 ` Maxim Kokryashkin via Tarantool-patches
2022-11-30 10:40 ` sergos via Tarantool-patches
2022-12-12 9:42 ` [Tarantool-patches] [PATCH luajit] " Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzWY05XuuRoy4Uds@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v2] Fix narrowing of unary minus.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox