From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Always fall back to metamethods for cdata length/concat.
Date: Mon, 12 Sep 2022 11:07:55 +0300 [thread overview]
Message-ID: <Yx7o219vecp4R4+4@root> (raw)
In-Reply-To: <1662644526.979269071@f508.i.mail.ru>
Hi, Maxim!
Thanks for the review!
On 08.09.22, Maxim Kokryashkin wrote:
>
> Hi, Sergey!
> Thanks for the patch!
> Please consider the single comment below:
>
> <snipped>
> >
> > src/lj_carith.c | 3 +--
> > src/lj_crecord.c | 6 ++++--
> > test/tarantool-tests/fix-cdata-concat.test.lua | 15 +++++++++++++++
> > 3 files changed, 20 insertions(+), 4 deletions(-)
> > create mode 100644 test/tarantool-tests/fix-cdata-concat.test.lua
> Besides everything that Sergos has already said, I wonder why you didn't include any changes in "lj_carith.h" and "lib_ffi.c" from the original patch?
They were annihilated during the cherry-pick. See the following changes
in the merge commit:
https://github.com/LuaJIT/LuaJIT/commit/d5e12d5174720fbd3c5fad4e02da5850b8433057
>
> <snipped>
> --
> Best regards,
> Maxim Kokryashkin
--
Best regards,
Sergey Kaplun
next parent reply other threads:[~2022-09-12 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1662644526.979269071@f508.i.mail.ru>
2022-09-12 8:07 ` Sergey Kaplun via Tarantool-patches [this message]
2022-09-13 7:32 ` Maxim Kokryashkin via Tarantool-patches
2022-08-23 14:27 Sergey Kaplun via Tarantool-patches
2022-08-31 10:02 ` sergos via Tarantool-patches
2022-09-22 9:36 ` Sergey Kaplun via Tarantool-patches
2022-11-11 8:54 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx7o219vecp4R4+4@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] FFI: Always fall back to metamethods for cdata length/concat.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox