From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3DEE16F153; Mon, 12 Sep 2022 11:10:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3DEE16F153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1662970238; bh=gbGU68lkuoa+dU5BXUVO5cIl+HPIujlAln/6uGuojg0=; h=Date:To:In-Reply-To:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=o589ZjH3iBw5PO6YH14HA6IB4K2Mf7/Muf8SQiTcCUD90UF4ZFP7nj2O+nYmISwaM unj8JK8PNn3qtbcq7fBJbA522MrrdZUga4+nair4zipcRwNREJcWQdcYF4AI7kVN7j BEO4UufH4+hNyFfSfxOLFdoEmOI9r3zeFCa6KmJg= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A10FB6F153 for ; Mon, 12 Sep 2022 11:10:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A10FB6F153 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1oXeWZ-0004PZ-Hl; Mon, 12 Sep 2022 11:10:35 +0300 Date: Mon, 12 Sep 2022 11:07:55 +0300 To: Maxim Kokryashkin Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1662644526.979269071@f508.i.mail.ru> X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD98A32D11463CB84D87C8E7E229E76C8F01ECC6AB3E654F362182A05F53808504066A49620BDF8872CCF6520B84BAFB266B9B89CF81939288B09131739E85A48E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F12ABE79F2AB44EAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063732727FD5A4355FD18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80408173A9D3C336DE09196317207796A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC109CDBF71E2B98BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CEB7D890E3377C531302FCEF25BFAB3454AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C30E0DD297EED076AEBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7F45C1E71A9DFFA2A731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B06604ACF793451CC562A0B7FAC1A43EF04A11A6841EAB5F08C0ACF30EC123FC6D9C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3419891600CCEF46075F103D6D2E1489AA2DCA756591BE506CCB08A2269E575276CF470F4C19BE9AD81D7E09C32AA3244C86FD7819977C6F2F567EFE7A13718413250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojlrfVkOjGUc/qjOooKldCAA== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF0DEF1D49E60ECB40850C228D12231A4A93CC837AFBA0EBF0BF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Always fall back to metamethods for cdata length/concat. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! On 08.09.22, Maxim Kokryashkin wrote: > > Hi, Sergey! > Thanks for the patch! > Please consider the single comment below: >   > > > > > src/lj_carith.c | 3 +-- > > src/lj_crecord.c | 6 ++++-- > > test/tarantool-tests/fix-cdata-concat.test.lua | 15 +++++++++++++++ > > 3 files changed, 20 insertions(+), 4 deletions(-) > > create mode 100644 test/tarantool-tests/fix-cdata-concat.test.lua > Besides everything that Sergos has already said, I wonder why you didn't include any changes in "lj_carith.h" and "lib_ffi.c" from the original patch? They were annihilated during the cherry-pick. See the following changes in the merge commit: https://github.com/LuaJIT/LuaJIT/commit/d5e12d5174720fbd3c5fad4e02da5850b8433057 >   > > -- > Best regards, > Maxim Kokryashkin -- Best regards, Sergey Kaplun