From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2] Cleanup math function compilation and fix inconsistencies. Date: Mon, 22 Aug 2022 12:40:51 +0300 [thread overview] Message-ID: <YwNPI8Tg4kSV7uTH@root> (raw) In-Reply-To: <20220818232823.96280-1-m.kokryashkin@tarantool.org> Hi, Maxim! Thanks for the patch! LGTM. On 19.08.22, Maxim Kokryashkin wrote: > This patch changes 'math_unary', `math_htrig` and `math_atrig` > to `math_call` for math functions compilation. Now all of > math functions in IRs are called with `CALLN` instead of > `FPMATH` (`ATAN2` for `math.atan2`). > > The `ATAN2` instruction itself is removed, as well as the fold > optimization for it. > > Also, this patch adds new fold optimizations for `CALLN`. > > Part of tarantool/tarantool#7230 > --- > As we decided offline, no tests are provided with this patch, because > of their extreme complexity with no real benefits. > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7230-cleanup-math-inconsistencies > PR: https://github.com/tarantool/tarantool/pull/7586 > > src/lib_math.c | 22 +++++++++++----------- > src/lj_asm.c | 6 ------ > src/lj_asm_arm.h | 1 - > src/lj_asm_arm64.h | 1 - > src/lj_asm_x86.h | 2 -- > src/lj_ffrecord.c | 19 ++----------------- > src/lj_ir.h | 4 +--- > src/lj_ircall.h | 14 +++++++++----- > src/lj_opt_fold.c | 25 ++++++++++++++++++++++++- > src/lj_opt_split.c | 3 --- > src/lj_target_x86.h | 6 ------ > src/lj_vmmath.c | 6 ------ > 12 files changed, 47 insertions(+), 62 deletions(-) > <snipped> > -- > 2.36.1 > -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2022-08-22 9:43 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-18 23:28 Maxim Kokryashkin via Tarantool-patches 2022-08-22 9:40 ` Sergey Kaplun via Tarantool-patches [this message] 2022-11-09 12:50 ` sergos via Tarantool-patches 2022-11-16 10:52 ` Maxim Kokryashkin via Tarantool-patches 2022-11-16 10:56 ` Maxim Kokryashkin via Tarantool-patches 2022-11-23 7:50 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YwNPI8Tg4kSV7uTH@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2] Cleanup math function compilation and fix inconsistencies.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox