Re: [Tarantool-patches] [PATCH luajit 7/8] ci: merge x86_64 and ARM64 workflows

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Igor!

Thanks for the patch!
LGTM!

On 11.08.22, Igor Munkin wrote:
> As a result of the previous commit, there is no difference left between
> x86_64 and ARM64 workflows except the runner where workflow is run.
> Hence there is no reason to have a separate workflow file for each
> hardware architecture.
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>  .github/workflows/linux-aarch64.yml           | 83 -----------------
>  .../workflows/{linux-x86_64.yml => linux.yml} | 52 ++++++++---
>  .github/workflows/macos-m1.yml                | 92 -------------------
>  .../workflows/{macos-x86_64.yml => macos.yml} | 52 ++++++++---
>  4 files changed, 82 insertions(+), 197 deletions(-)
>  delete mode 100644 .github/workflows/linux-aarch64.yml
>  rename .github/workflows/{linux-x86_64.yml => linux.yml} (69%)
>  delete mode 100644 .github/workflows/macos-m1.yml
>  rename .github/workflows/{macos-x86_64.yml => macos.yml} (73%)
> 
> diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
> deleted file mode 100644
> index 21d86764..00000000
> --- a/.github/workflows/linux-aarch64.yml
> +++ /dev/null
> @@ -1,83 +0,0 @@

<snipped>

> diff --git a/.github/workflows/linux-x86_64.yml b/.github/workflows/linux.yml
> similarity index 69%
> rename from .github/workflows/linux-x86_64.yml
> rename to .github/workflows/linux.yml
> index 4c3ad4c7..125c8708 100644
> --- a/.github/workflows/linux-x86_64.yml
> +++ b/.github/workflows/linux.yml

<snipped>

> @@ -65,8 +77,8 @@ jobs:
>          run: cmake --build . --parallel --target test
>          working-directory: ${{ env.BUILDDIR }}
>  
> -  test-tarantool-debug-wo-GC64:
> -    name: Tarantool Debug GC64:OFF
> +  test-tarantool-x86_64-debug-wo-GC64:

Side note: Can we use the same matrix approach for integration
workflows?

> +    name: Tarantool x86_64 Debug GC64:OFF
>      needs: test-luajit
>      uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>      with:
> @@ -74,8 +86,8 @@ jobs:
>        buildtype: Debug
>        host: ubuntu-20.04-self-hosted
>        revision: ${{ github.sha }}
> -  test-tarantool-debug-w-GC64:
> -    name: Tarantool Debug GC64:ON
> +  test-tarantool-x86_64-debug-w-GC64:
> +    name: Tarantool x86_64 Debug GC64:ON
>      needs: test-luajit
>      uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>      with:
> @@ -83,8 +95,8 @@ jobs:
>        buildtype: Debug
>        host: ubuntu-20.04-self-hosted
>        revision: ${{ github.sha }}
> -  test-tarantool-release-wo-GC64:
> -    name: Tarantool Release GC64:OFF
> +  test-tarantool-x86_64-release-wo-GC64:
> +    name: Tarantool x86_64 Release GC64:OFF
>      needs: test-luajit
>      uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>      with:
> @@ -92,8 +104,8 @@ jobs:
>        buildtype: RelWithDebInfo
>        host: ubuntu-20.04-self-hosted
>        revision: ${{ github.sha }}
> -  test-tarantool-release-w-GC64:
> -    name: Tarantool Release GC64:ON
> +  test-tarantool-x86_64-release-w-GC64:
> +    name: Tarantool x86_64 Release GC64:ON
>      needs: test-luajit
>      uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
>      with:
> @@ -101,3 +113,21 @@ jobs:

<snipped>

> diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml
> deleted file mode 100644
> index 4e1275f7..00000000
> --- a/.github/workflows/macos-m1.yml
> +++ /dev/null
> @@ -1,92 +0,0 @@

<snipped>

> -- 
> 2.34.0
> 

-- 
Best regards,
Sergey Kaplun