From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix IR_VARG offset for fixed number of results. Date: Tue, 19 Jul 2022 03:14:18 +0300 [thread overview] Message-ID: <YtX3Wj+Uc4OPOw+8@tarantool.org> (raw) In-Reply-To: <20220713095349.31718-1-skaplun@tarantool.org> Sergey, Thanks for your patch! LGTM, after the fixes you've made[1] against Sergos' review comments. On 13.07.22, Sergey Kaplun wrote: > From: Mike Pall <mike> > > Reported by George Vaintrub. Fixed by Sergey Kaplun. > > (cherry picked from commit 6bda30d8c745b3963ba870221b9be6acdffed9b1) > > This bug occurs when recording `BC_VARG` with the following conditions: > 1) varargs undefined on trace. > 2) known fixed number of results. > > For this case the vararg slots loads via `IR_VLOAD` by offset from > vararg base. In GC64 mode this offset was miscounting due to missing > `LJ_FR2` correction in the base TRef calculation. As the result the > wrong (+1) vararg slot is used. > > This patch adds the missing the aforementioned `LJ_FR2` correction. > > Sergey Kaplun: > * added the description and the test for the problem > > Resolves tarantool/tarantool#7172 > Part of tarantool/tarantool#7230 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-864-varg-rec-base-offset-full-ci > Issues: > * https://github.com/tarantool/tarantool/issues/7172 > * https://github.com/LuaJIT/LuaJIT/issues/864 > > src/lj_record.c | 2 +- > .../lj-864-varg-rec-base-offset.test.lua | 25 +++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-864-varg-rec-base-offset.test.lua > <snipped> > -- > 2.34.1 > [1]: https://github.com/tarantool/luajit/commit/5dbc5ab -- Best regards, IM
next prev parent reply other threads:[~2022-07-19 0:14 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-13 9:53 Sergey Kaplun via Tarantool-patches 2022-07-14 11:54 ` sergos via Tarantool-patches 2022-07-15 14:44 ` Sergey Kaplun via Tarantool-patches 2022-07-15 15:03 ` sergos via Tarantool-patches 2022-07-19 0:14 ` Igor Munkin via Tarantool-patches [this message] 2022-08-10 14:32 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YtX3Wj+Uc4OPOw+8@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix IR_VARG offset for fixed number of results.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox