From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EEE096ECE3; Tue, 19 Jul 2022 03:14:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EEE096ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1658189667; bh=SaUKDJnuMYohvJ8XD+rCpUyzn0Y0bb90ObNEn6kDYLM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F5f+q1S5MsexvvZnwvaqAqiyJYY3oK7LVmW+97Ck3Umpf5iLJe/kshGokMlQdpi92 5pDnqtEApawzH+jP8fIAoZ842GhP4X9AiqzIt/CbvHhaPV/cMyuZjCoDhrYKEv9HcI HH7zVBEa5L61udDD5F6wdpYMfGjAVTBJ0k3UdRYw= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 638046ECE3 for ; Tue, 19 Jul 2022 03:14:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 638046ECE3 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1oDasa-0007wG-7m; Tue, 19 Jul 2022 03:14:24 +0300 Date: Tue, 19 Jul 2022 03:14:18 +0300 To: Sergey Kaplun Message-ID: References: <20220713095349.31718-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220713095349.31718-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97CF746166DCF1A14353570ADF0D1F7EACACF57C6E22340B6182A05F53808504079B3AD0E823599B794F5A654A77C06D3B52D66D1F66810A52A3E1120ADA999A3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377EB37407B8EEC8CE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89CDC0DBAC4F0F754327799388827DB7C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A62CEF541B197C8089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B06604ACF793451CC54B91265EEBC6D5970043C653EBEA6D03075033CD6A4722A29C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343536C6A4332D8B8A916CC74A9959B00175CF313C7EF68D1230211B9DAC54834BBA30D7680C3A46B21D7E09C32AA3244CC46A6D728D7C54FFF865BC705542498D3E8609A02908F271927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxsYw4WntCY4RdGUB6m003g== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E24DB955D75B59F5F01256C6FA51BF8ADA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix IR_VARG offset for fixed number of results. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your patch! LGTM, after the fixes you've made[1] against Sergos' review comments. On 13.07.22, Sergey Kaplun wrote: > From: Mike Pall > > Reported by George Vaintrub. Fixed by Sergey Kaplun. > > (cherry picked from commit 6bda30d8c745b3963ba870221b9be6acdffed9b1) > > This bug occurs when recording `BC_VARG` with the following conditions: > 1) varargs undefined on trace. > 2) known fixed number of results. > > For this case the vararg slots loads via `IR_VLOAD` by offset from > vararg base. In GC64 mode this offset was miscounting due to missing > `LJ_FR2` correction in the base TRef calculation. As the result the > wrong (+1) vararg slot is used. > > This patch adds the missing the aforementioned `LJ_FR2` correction. > > Sergey Kaplun: > * added the description and the test for the problem > > Resolves tarantool/tarantool#7172 > Part of tarantool/tarantool#7230 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-864-varg-rec-base-offset-full-ci > Issues: > * https://github.com/tarantool/tarantool/issues/7172 > * https://github.com/LuaJIT/LuaJIT/issues/864 > > src/lj_record.c | 2 +- > .../lj-864-varg-rec-base-offset.test.lua | 25 +++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-864-varg-rec-base-offset.test.lua > > -- > 2.34.1 > [1]: https://github.com/tarantool/luajit/commit/5dbc5ab -- Best regards, IM