From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] sysprof: fix inconsistencies
Date: Mon, 18 Jul 2022 20:23:31 +0300 [thread overview]
Message-ID: <YtWXE8PayVMTBX/0@tarantool.org> (raw)
In-Reply-To: <cover.1656883823.git.m.kokryashkin@tarantool.org>
Max,
Thanks for the patch! LGTM, after the fixes you've made[1] against Sergey's
review comments.
On 04.07.22, Maxim Kokryashkin wrote:
> This patch set improves the LuaJIT's symtab resolution, by making
> the `lj_symtab` module read the `.symtab` section instead
> of `.dynsym`.
>
> Also, it changes the stack merge algorithm in the parser,
> providing support for sandwiched stacks.
>
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7244-sysprof-sandwich
> PR: https://github.com/tarantool/tarantool/pull/7342
>
> Maxim Kokryashkin (2):
> symtab: fix static symtab dump
> sysprof: add stack sandwich support
>
> src/lj_symtab.c | 28 ++++++++++++++++++++++++++++
> tools/sysprof/collapse.lua | 31 +++++++++++++++++++------------
> 2 files changed, 47 insertions(+), 12 deletions(-)
>
> --
> 2.36.1
>
[1]: https://github.com/tarantool/luajit/commit/dfa0f97
--
Best regards,
IM
next prev parent reply other threads:[~2022-07-18 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 21:38 Maxim Kokryashkin via Tarantool-patches
2022-07-03 21:38 ` [Tarantool-patches] [PATCH luajit 1/2] symtab: fix static symtab dump Maxim Kokryashkin via Tarantool-patches
2022-07-16 7:21 ` Sergey Kaplun via Tarantool-patches
2022-07-03 21:38 ` [Tarantool-patches] [PATCH luajit 2/2] sysprof: add stack sandwich support Maxim Kokryashkin via Tarantool-patches
2022-07-16 7:32 ` Sergey Kaplun via Tarantool-patches
2022-07-18 17:23 ` Igor Munkin via Tarantool-patches [this message]
2022-08-10 14:34 ` [Tarantool-patches] [PATCH luajit 0/2] sysprof: fix inconsistencies Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtWXE8PayVMTBX/0@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit 0/2] sysprof: fix inconsistencies' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox