From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E4A0D6ECE3; Mon, 18 Jul 2022 20:23:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E4A0D6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1658165020; bh=Wgan+SUPFUFwASzqftmV0sfg5V/a2pGS2ejE8cmVBpQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JW1Qbr+KeXITx+gEFek8Ha0OYdOfCdbFAu5T8MlHf0ipkg66hDYraPsUuO+shMzhL lPnj0/bk0qfl2peHTR7AxgvcQQPO3Kdb2/SaphTOWXin7ZBJqm6IeeqFfp/binJMAP asafs9eUSrw07BKWrcOSwcp0MOVuI5yY1kZcO1zI= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C57B56ECE3 for ; Mon, 18 Jul 2022 20:23:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C57B56ECE3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1oDUT2-0005Ey-Jm; Mon, 18 Jul 2022 20:23:37 +0300 Date: Mon, 18 Jul 2022 20:23:31 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97CF746166DCF1A14353570ADF0D1F7EACACF57C6E22340B6182A05F5380850404594B01CDB4386916DC737731D9774EF8880CA0FAAB6995A0358175AA6919D5B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE712EB008F780777E9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063739E242D0556ED1DD8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DF60A435D1636FEEACF98EAF4226A909117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A62CEF541B197C8089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0F56C66D0505D98344B91265EEBC6D5976418F73819D2BC9095508837A433343E9C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B8CF715B894FC711239E0E4221CA1F6EB3B134971B9C39036A9C60001BBD709013606E65E4B0C0821D7E09C32AA3244C530592AE4D18278472CE0656DC2482493E8609A02908F27183B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxsYw4WntCY5XZut8ZAtDpA== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EBFFCAF0D0B22F5885AAC234024D85FBBA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] sysprof: fix inconsistencies X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM, after the fixes you've made[1] against Sergey's review comments. On 04.07.22, Maxim Kokryashkin wrote: > This patch set improves the LuaJIT's symtab resolution, by making > the `lj_symtab` module read the `.symtab` section instead > of `.dynsym`. > > Also, it changes the stack merge algorithm in the parser, > providing support for sandwiched stacks. > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7244-sysprof-sandwich > PR: https://github.com/tarantool/tarantool/pull/7342 > > Maxim Kokryashkin (2): > symtab: fix static symtab dump > sysprof: add stack sandwich support > > src/lj_symtab.c | 28 ++++++++++++++++++++++++++++ > tools/sysprof/collapse.lua | 31 +++++++++++++++++++------------ > 2 files changed, 47 insertions(+), 12 deletions(-) > > -- > 2.36.1 > [1]: https://github.com/tarantool/luajit/commit/dfa0f97 -- Best regards, IM