Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: configure parallel jobs
Date: Mon, 4 Jul 2022 12:52:30 +0300	[thread overview]
Message-ID: <YsK4XrTgtcStVJzw@root> (raw)
In-Reply-To: <62acf609d9e1ea43d95cb27213e1b8f1331b57a7.1656685987.git.sergeyb@tarantool.org>

Hi, Sergey!

Thanks for the patch!

LGTM, except a few nits regarding the commit message.

On 01.07.22, Sergey Bronnikov wrote:
> lua-Harness and tarantool testsuites uses a prove(1) for running tests.

Typo: s/testsuites/test suites/

> prove(1) allows to run tests in parallel with option "--jobs" [1].

Typo: s/option/the option/

> 
> In CMake it is not possible to get a number of parallel jobs in CMake
> passed by user with option "-j", but it allows to pass a number of
> parallel jobs with environment variable CMAKE_BUILD_PARALLEL_LEVEL [2]
> on configuration phase. We use a value set by that environment variable
> and set it to a number of CPU threads when it was not specified by user.

Typo: s/user/the user/

> Number of CPU threads detected using builtin CMake function [3].
> 
> NOTE: CMAKE_BUILD_PARALLEL_LEVEL has been added in a version 3.12.
> 
> 1. https://perldoc.perl.org/prove
> 2. https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html
> 3. https://cmake.org/cmake/help/latest/module/ProcessorCount.html
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/ligurio/prove-in-parallel
> CI: https://github.com/tarantool/luajit/commit/62acf609d9e1ea43d95cb27213e1b8f1331b57a7
> 
>  test/CMakeLists.txt                   | 13 +++++++++++++
>  test/lua-Harness-tests/CMakeLists.txt |  1 +
>  test/tarantool-tests/CMakeLists.txt   |  1 +
>  3 files changed, 15 insertions(+)
> 

<snipped>

> -- 
> 2.25.1
> 

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2022-07-04  9:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 14:36 Sergey Bronnikov via Tarantool-patches
2022-07-04  9:52 ` Sergey Kaplun via Tarantool-patches [this message]
2022-07-04 10:06   ` Sergey Bronnikov via Tarantool-patches
2022-07-04 10:12 ` Igor Munkin via Tarantool-patches
2022-07-04 14:21   ` Sergey Bronnikov via Tarantool-patches
2022-07-05 21:22     ` Igor Munkin via Tarantool-patches
2022-07-06 10:32       ` Sergey Bronnikov via Tarantool-patches
2022-07-13 10:10 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsK4XrTgtcStVJzw@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] build: configure parallel jobs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox