From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4426E6ECE3; Mon, 4 Jul 2022 12:54:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4426E6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656928490; bh=1+A666GABWxasgpXayaIyEjLhFu3f3vmNiNxcrex7y4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BrdU6RnQa6Xfu5qHFuPBueCKC+xmgMaaF7dSFJGZ4glJLE+df/Rti/1yNaLlgHhh4 S+LG3MrkIe8Y8c70IvBY9fEB83tYWeGBkKmyk00otr4LGsCdBqWBUWvjQo2AFtvtH8 gWTpEjsggtw60vLnYIohw3m06mW/1iQ1ivXS/Rzo= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8B17A6ECE3 for ; Mon, 4 Jul 2022 12:54:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8B17A6ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o8In2-0000JJ-OA; Mon, 04 Jul 2022 12:54:49 +0300 Date: Mon, 4 Jul 2022 12:52:30 +0300 To: Sergey Bronnikov Message-ID: References: <62acf609d9e1ea43d95cb27213e1b8f1331b57a7.1656685987.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62acf609d9e1ea43d95cb27213e1b8f1331b57a7.1656685987.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597DA2C2EA0BB6343F2AA7D0956CEC736A9CCD62213F67905E7A2D9E6D0DDF0733D0F4121295E44B05069891DDD7AEE082FB31E418E160CADA48 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D6964C9E324ABA58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FD60A286D0BA57028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B7999E006090087D7A618464E4FE4C15117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BECADA55FE5B58BB7A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C565C1E6824D8037B43847C11F186F3C59DAA53EE0834AAEE X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C26685591D53E7C75FF498678A34394BDC02C103E5159ED8BAD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348D68DCC07DD06FF51305AAD3C305DFDA03A3DAB75A402E045449DC24FFE1F2D25EA8CF6B165E40C31D7E09C32AA3244CF521F4A5A010A2DF84DBB3903107FA6DA90944CA99CF22E3927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoR2RQGvSEnRKx/BBMDe3Hg== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E27FAC128B89E658964FC90EE1C5545E10FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: configure parallel jobs X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except a few nits regarding the commit message. On 01.07.22, Sergey Bronnikov wrote: > lua-Harness and tarantool testsuites uses a prove(1) for running tests. Typo: s/testsuites/test suites/ > prove(1) allows to run tests in parallel with option "--jobs" [1]. Typo: s/option/the option/ > > In CMake it is not possible to get a number of parallel jobs in CMake > passed by user with option "-j", but it allows to pass a number of > parallel jobs with environment variable CMAKE_BUILD_PARALLEL_LEVEL [2] > on configuration phase. We use a value set by that environment variable > and set it to a number of CPU threads when it was not specified by user. Typo: s/user/the user/ > Number of CPU threads detected using builtin CMake function [3]. > > NOTE: CMAKE_BUILD_PARALLEL_LEVEL has been added in a version 3.12. > > 1. https://perldoc.perl.org/prove > 2. https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html > 3. https://cmake.org/cmake/help/latest/module/ProcessorCount.html > --- > > Branch: https://github.com/tarantool/luajit/tree/ligurio/prove-in-parallel > CI: https://github.com/tarantool/luajit/commit/62acf609d9e1ea43d95cb27213e1b8f1331b57a7 > > test/CMakeLists.txt | 13 +++++++++++++ > test/lua-Harness-tests/CMakeLists.txt | 1 + > test/tarantool-tests/CMakeLists.txt | 1 + > 3 files changed, 15 insertions(+) > > -- > 2.25.1 > -- Best regards, Sergey Kaplun