Re: [Tarantool-patches] [PATCH] build: configure parallel jobs

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!

Thanks for the patch!

LGTM, except a few nits regarding the commit message.

On 01.07.22, Sergey Bronnikov wrote:
> lua-Harness and tarantool testsuites uses a prove(1) for running tests.

Typo: s/testsuites/test suites/

> prove(1) allows to run tests in parallel with option "--jobs" [1].

Typo: s/option/the option/

> 
> In CMake it is not possible to get a number of parallel jobs in CMake
> passed by user with option "-j", but it allows to pass a number of
> parallel jobs with environment variable CMAKE_BUILD_PARALLEL_LEVEL [2]
> on configuration phase. We use a value set by that environment variable
> and set it to a number of CPU threads when it was not specified by user.

Typo: s/user/the user/

> Number of CPU threads detected using builtin CMake function [3].
> 
> NOTE: CMAKE_BUILD_PARALLEL_LEVEL has been added in a version 3.12.
> 
> 1. https://perldoc.perl.org/prove
> 2. https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html
> 3. https://cmake.org/cmake/help/latest/module/ProcessorCount.html
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/ligurio/prove-in-parallel
> CI: https://github.com/tarantool/luajit/commit/62acf609d9e1ea43d95cb27213e1b8f1331b57a7
> 
>  test/CMakeLists.txt                   | 13 +++++++++++++
>  test/lua-Harness-tests/CMakeLists.txt |  1 +
>  test/tarantool-tests/CMakeLists.txt   |  1 +
>  3 files changed, 15 insertions(+)
> 

<snipped>

> -- 
> 2.25.1
> 

-- 
Best regards,
Sergey Kaplun