Re: [Tarantool-patches] [PATCH luajit 1/3] ci: fix --parallel argument for MacOS runners

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for your review! See my comments inline and the changes on the
remote branch[1].

On 23.06.22, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> 
> LGTM, except a few nits regarding the commit message.

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> 
> On 22.06.22, Igor Munkin wrote:
> > In scope of the commit 4195eb8f7e2abcf75f92eedd2859b7991cc8b363 ("ci:
> 
> Typo: s/In scope/In the scope/

I strongly doubt. Ignoring.

> 
> > make GitHub workflows more CMake-ish") --parallel value has been
> > explicitly set to $(nproc) + 1, since -j default behaviour differs for
> > Ninja and GnuMake. However, MacOS lacks nproc command, but CI silently
> > continues to execute pipeline.
> 
> Typo: s/pipeline/the pipeline/

Fixed.

> 
> > 
> > This patch fixed MacOS-specific workflows changing nproc command with
> 
> Nit: s/fixed/fixes/ as far as we prefer Present Simple for commits
> description.
> Feel free to ignore.

You're right, thanks! Fixed.

> 
> > sysctl -n hw.ncpu.
> > 
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
> 
> <snipped>
> 
> > -- 
> > 2.34.0
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

[1]: https://github.com/tarantool/luajit/commit/fe2df4c

-- 
Best regards,
IM