Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Handle zero-fill of struct-of-NYI.
Date: Wed, 29 Jun 2022 11:02:29 +0300	[thread overview]
Message-ID: <YrwHFa72rWlPRwwx@tarantool.org> (raw)
In-Reply-To: <20220506045339.8919-1-skaplun@tarantool.org>

Sergey,

Thanks for the patch! LGTM, with a little tweak for commit message:
| FFI: Handle zero-fill of struct-of-NYI.
|
| (cherry picked from ad65934fa08a65bfb0eb9528731a4394842cc173)
|
| Trace recording is aborted with NYI reason for the case of a struct with
| aggregate allocation. The general solution is way too complex due to
| heterogeneous initialization of the structure. However, zero-fill case
| requires nothing but "memset"-like initialization of GCcdata payload.
|
| As a result of this patch workaround for the zero-fill structures is
| introduced.
|
| Sergey Kaplun:
| * added the description and the test for the problem
|
| Part of tarantool/tarantool#6548
| Related to tarantool/tarantool#4630
| Related to tarantool/tarantool#5885

-- 
Best regards,
IM

  parent reply	other threads:[~2022-06-29  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06  4:53 Sergey Kaplun via Tarantool-patches
2022-06-21 13:44 ` sergos via Tarantool-patches
2022-06-29  8:02 ` Igor Munkin via Tarantool-patches [this message]
2022-06-30 12:11 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrwHFa72rWlPRwwx@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] FFI: Handle zero-fill of struct-of-NYI.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox